From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74773C433F5 for ; Mon, 17 Jan 2022 15:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240466AbiAQPaj (ORCPT ); Mon, 17 Jan 2022 10:30:39 -0500 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:56564 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235076AbiAQPah (ORCPT ); Mon, 17 Jan 2022 10:30:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1642433437; x=1673969437; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=R+tQljwCBcc53ZZwDY25faMMYMKhPafqnn86cE7TQiw=; b=U5REhn0CPn+sO2o1TJiUVY21D9JZk9nbpVFyYepiMc6LcPGt/m+OOwI8 HQx/y45a7dFkiOtboEKUoAnQrlMPicn6tl0ZzTmQ7U9LB+P6BOsWBD+ty /KURLhU26fU9+ZFaG6MGdWio0CNGtUQ/KvWbKsu2t/vUQbKjXzYSq47IG 0=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-02.qualcomm.com with ESMTP; 17 Jan 2022 07:30:37 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2022 07:30:36 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 17 Jan 2022 07:30:36 -0800 Received: from [10.50.45.28] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 17 Jan 2022 07:30:31 -0800 Message-ID: <8bbe3552-cd47-c9d4-a296-ba446b7b2f45@quicinc.com> Date: Mon, 17 Jan 2022 21:00:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCHv8 4/5] lib: Add register read/write tracing support Content-Language: en-US To: Steven Rostedt CC: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , gregkh , , Trilok Soni , , , , Prasad Sodagudi References: <8ad60797d6d8f40c3bdba20b1678fa9014bc1a20.1642309054.git.quic_saipraka@quicinc.com> <20220117100314.416a4d68@rorschach.local.home> From: Sai Prakash Ranjan In-Reply-To: <20220117100314.416a4d68@rorschach.local.home> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, On 1/17/2022 8:33 PM, Steven Rostedt wrote: > On Mon, 17 Jan 2022 09:02:53 +0530 > Sai Prakash Ranjan wrote: > >> diff --git a/include/trace/events/rwmmio.h b/include/trace/events/rwmmio.h >> new file mode 100644 >> index 000000000000..798fbe1ac9f9 >> --- /dev/null >> +++ b/include/trace/events/rwmmio.h >> @@ -0,0 +1,112 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> +#undef TRACE_SYSTEM >> +#define TRACE_SYSTEM rwmmio >> + >> +#if !defined(_TRACE_RWMMIO_H) || defined(TRACE_HEADER_MULTI_READ) >> +#define _TRACE_RWMMIO_H >> + >> +#include >> + >> +TRACE_EVENT(rwmmio_write, >> + >> + TP_PROTO(unsigned long caller, u64 val, u8 width, volatile void __iomem *addr), >> + >> + TP_ARGS(caller, val, width, addr), >> + >> + TP_STRUCT__entry( >> + __field(u64, caller) >> + __field(u64, val) >> + __field(u64, addr) >> + __field(u8, width) >> + ), >> + >> + TP_fast_assign( >> + __entry->caller = caller; >> + __entry->val = val; >> + __entry->addr = (unsigned long)(void *)addr; >> + __entry->width = width; >> + ), >> + >> + TP_printk("%pS width=%d val=%#llx addr=%#llx", >> + (void *)(unsigned long)__entry->caller, __entry->width, >> + __entry->val, __entry->addr) >> +); >> + >> +TRACE_EVENT(rwmmio_post_write, >> + >> + TP_PROTO(unsigned long caller, u64 val, u8 width, volatile void __iomem *addr), >> + >> + TP_ARGS(caller, val, width, addr), >> + >> + TP_STRUCT__entry( >> + __field(u64, caller) >> + __field(u64, val) >> + __field(u64, addr) >> + __field(u8, width) >> + ), >> + >> + TP_fast_assign( >> + __entry->caller = caller; >> + __entry->val = val; >> + __entry->addr = (unsigned long)(void *)addr; >> + __entry->width = width; >> + ), >> + >> + TP_printk("%pS width=%d val=%#llx addr=%#llx", >> + (void *)(unsigned long)__entry->caller, __entry->width, >> + __entry->val, __entry->addr) >> +); >> + >> +TRACE_EVENT(rwmmio_read, >> + >> + TP_PROTO(unsigned long caller, u8 width, const volatile void __iomem *addr), >> + >> + TP_ARGS(caller, width, addr), >> + >> + TP_STRUCT__entry( >> + __field(u64, caller) >> + __field(u64, addr) >> + __field(u8, width) >> + ), >> + >> + TP_fast_assign( >> + __entry->caller = caller; >> + __entry->addr = (unsigned long)(void *)addr; >> + __entry->width = width; >> + ), >> + >> + TP_printk("%pS width=%d addr=%#llx", >> + (void *)(unsigned long)__entry->caller, __entry->width, __entry->addr) >> +); >> + >> +TRACE_EVENT(rwmmio_post_read, >> + >> + TP_PROTO(unsigned long caller, u64 val, u8 width, const volatile void __iomem *addr), >> + >> + TP_ARGS(caller, val, width, addr), >> + >> + TP_STRUCT__entry( >> + __field(u64, caller) >> + __field(u64, val) >> + __field(u64, addr) >> + __field(u8, width) >> + ), >> + >> + TP_fast_assign( >> + __entry->caller = caller; >> + __entry->val = val; >> + __entry->addr = (unsigned long)(void *)addr; >> + __entry->width = width; >> + ), >> + >> + TP_printk("%pS width=%d val=%#llx addr=%#llx", >> + (void *)(unsigned long)__entry->caller, __entry->width, >> + __entry->val, __entry->addr) >> +); > The above should be replaced with: > > DECLARE_EVENT_CLASS(rwmmio_rw_template, > > TP_PROTO(unsigned long caller, u64 val, u8 width, volatile void __iomem *addr), > > TP_ARGS(caller, val, width, addr), > > TP_STRUCT__entry( > __field(u64, caller) > __field(u64, val) > __field(u64, addr) > __field(u8, width) > ), > > TP_fast_assign( > __entry->caller = caller; > __entry->val = val; > __entry->addr = (unsigned long)(void *)addr; > __entry->width = width; > ), > > TP_printk("%pS width=%d val=%#llx addr=%#llx", > (void *)(unsigned long)__entry->caller, __entry->width, > __entry->val, __entry->addr) > ); > > DEFINE_EVENT(rwmmio_rw_template, rwmmio_write, > TP_PROTO(unsigned long caller, u64 val, u8 width, volatile void __iomem *addr), > TP_ARGS(caller, val, width, addr) > ); > > DEFINE_EVENT(rwmmio_rw_template, rwmmio_post_write, > TP_PROTO(unsigned long caller, u64 val, u8 width, volatile void __iomem *addr), > TP_ARGS(caller, val, width, addr) > ); > > DEFINE_EVENT(rwmmio_rw_template, rwmmio_post_read, > TP_PROTO(unsigned long caller, u64 val, u8 width, volatile void __iomem *addr), > TP_ARGS(caller, val, width, addr) > ); > > It will save around 15k in memory. > > And since rwmmio_read doesn't have a val field, it can stay a TRACE_EVENT. > > TRACE_EVENT(rwmmio_read, > > TP_PROTO(unsigned long caller, u8 width, const volatile void __iomem *addr), > > TP_ARGS(caller, width, addr), > > TP_STRUCT__entry( > __field(u64, caller) > __field(u64, addr) > __field(u8, width) > ), > > TP_fast_assign( > __entry->caller = caller; > __entry->addr = (unsigned long)(void *)addr; > __entry->width = width; > ), > > TP_printk("%pS width=%d addr=%#llx", > (void *)(unsigned long)__entry->caller, __entry->width, __entry->addr) > ); > > -- Steve Thanks for the review, will add these changes in next version. Thanks, Sai >> + >> +#endif /* _TRACE_RWMMIO_H */ >> + >> +#include >> diff --git a/lib/Kconfig b/lib/Kconfig >> index c80fde816a7e..ea520c315c0f 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -119,6 +119,13 @@ config INDIRECT_IOMEM_FALLBACK >> mmio accesses when the IO memory address is not a registered >> emulated region. >> >> +config TRACE_MMIO_ACCESS >> + bool "Register read/write tracing" >> + depends on TRACING && ARCH_HAVE_TRACE_MMIO_ACCESS >> + help >> + Create tracepoints for MMIO read/write operations. These trace events >> + can be used for logging all MMIO read/write operations. >> + >> source "lib/crypto/Kconfig" >> >> config CRC_CCITT >> diff --git a/lib/Makefile b/lib/Makefile >> index 300f569c626b..43813b0061cd 100644 >> --- a/lib/Makefile >> +++ b/lib/Makefile >> @@ -152,6 +152,8 @@ lib-y += logic_pio.o >> >> lib-$(CONFIG_INDIRECT_IOMEM) += logic_iomem.o >> >> +obj-$(CONFIG_TRACE_MMIO_ACCESS) += trace_readwrite.o >> + >> obj-$(CONFIG_GENERIC_HWEIGHT) += hweight.o >> >> obj-$(CONFIG_BTREE) += btree.o >> diff --git a/lib/trace_readwrite.c b/lib/trace_readwrite.c >> new file mode 100644 >> index 000000000000..88637038b30c >> --- /dev/null >> +++ b/lib/trace_readwrite.c >> @@ -0,0 +1,47 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Register read and write tracepoints >> + * >> + * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +#include >> +#include >> +#include >> + >> +#define CREATE_TRACE_POINTS >> +#include >> + >> +#ifdef CONFIG_TRACE_MMIO_ACCESS >> +void log_write_mmio(u64 val, u8 width, volatile void __iomem *addr, >> + unsigned long caller_addr) >> +{ >> + trace_rwmmio_write(caller_addr, val, width, addr); >> +} >> +EXPORT_SYMBOL_GPL(log_write_mmio); >> +EXPORT_TRACEPOINT_SYMBOL_GPL(rwmmio_write); >> + >> +void log_post_write_mmio(u64 val, u8 width, volatile void __iomem *addr, >> + unsigned long caller_addr) >> +{ >> + trace_rwmmio_post_write(caller_addr, val, width, addr); >> +} >> +EXPORT_SYMBOL_GPL(log_post_write_mmio); >> +EXPORT_TRACEPOINT_SYMBOL_GPL(rwmmio_post_write); >> + >> +void log_read_mmio(u8 width, const volatile void __iomem *addr, >> + unsigned long caller_addr) >> +{ >> + trace_rwmmio_read(caller_addr, width, addr); >> +} >> +EXPORT_SYMBOL_GPL(log_read_mmio); >> +EXPORT_TRACEPOINT_SYMBOL_GPL(rwmmio_read); >> + >> +void log_post_read_mmio(u64 val, u8 width, const volatile void __iomem *addr, >> + unsigned long caller_addr) >> +{ >> + trace_rwmmio_post_read(caller_addr, val, width, addr); >> +} >> +EXPORT_SYMBOL_GPL(log_post_read_mmio); >> +EXPORT_TRACEPOINT_SYMBOL_GPL(rwmmio_post_read); >> +#endif /* CONFIG_TRACE_MMIO_ACCESS */