From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753397AbcHQLd1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Aug 2016 07:33:27 -0400
Received: from bear.ext.ti.com ([198.47.19.11]:51633 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752545AbcHQLdZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Aug 2016 07:33:25 -0400
Subject: Re: [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card
To: Karl Beldan <kbeldan@baylibre.com>
References: <20160810200853.24275-1-kbeldan@baylibre.com>
 <aeec6ee5-91e9-13fa-f7fa-09581ddb9b6a@ti.com> <20160817103346.GB8009@gobelin>
CC: <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        Kevin Hilman <khilman@baylibre.com>,
        Karl Beldan <karl.beldan+oss@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>
From: Sekhar Nori <nsekhar@ti.com>
Message-ID: <8bc04130-0e0f-1c5d-43ad-3755b22295e5@ti.com>
Date: Wed, 17 Aug 2016 17:02:13 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160817103346.GB8009@gobelin>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 17 August 2016 04:03 PM, Karl Beldan wrote:
> On Wed, Aug 17, 2016 at 03:24:42PM +0530, Sekhar Nori wrote:
>> On Thursday 11 August 2016 01:38 AM, Karl Beldan wrote:
>>> The LCDK embeds a TLV320AIC3106 connected to the SoC McASP for analog
>>> audio. This relies on the 'dummy' regulator as the codec is always on.
>>> Quality is good with arecord -pipe- aplay on Line In/Line Out.
>>> The MIC path doesn't seem to work yet.
>>
>> I tested the patch and I could not get the MIC to work as well. I
>> suggest dropping the MIC path parts till that is debugged and root caused.
>>
> 
> Ok.
> 
>>> Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
>>> ---
>>>  arch/arm/boot/dts/da850-lcdk.dts | 75 ++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 75 insertions(+)
>>
>>> +&i2c0 {
>>> +	pinctrl-names = "default";
>>> +	pinctrl-0 = <&i2c0_pins>;
>>> +	clock-frequency = <100000>;
>>> +	status = "okay";
>>> +
>>> +	tlv320aic3106: tlv320aic3106@18 {
>>> +		#sound-dai-cells = <0>;
>>> +		compatible = "ti,tlv320aic3106";
>>> +		reg = <0x18>;
>>> +		status = "okay";
>>> +
>>> +		ai3x-micbias-vg = <MICBIAS_2_5V>;
>>
>> It will be nice to add the codec regulators as well (and that in turn
>> needs the PMIC to be populated). Although I wont insist on that since
>> the regulators are optional properties.
>>
> 
> In the patch comment I stated it relied on the dummy regulator as the
> codec is always on but maybe I should have been more precise: it is not
> out of convenience to keep things on, it is by HW design: I mentioned
> it in the comment of "ARM: dts: da850: Add basic DTS for the LCDK":
>  "the main PMIC, different and hard-wired on the LCDK (the LDOs and
>  DCDCs are always on)" after reviewing the schematics.
> I could add that in the patch comment.

I see. PMIC on the LCDK is not software configurable at all. I think
what you have in the patch comment is already okay. More explanation
wont harm though :)

Regards,
Sekhar