From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jianmin Lv <lvjianmin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, diasyzhang@tencent.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: loongson,liointc: Fix warnings about liointc-2.0
Date: Mon, 4 Sep 2023 09:40:07 +0200 [thread overview]
Message-ID: <8bc40c78-9d5a-ea23-586a-5cf38845bfaf@linaro.org> (raw)
In-Reply-To: <3ed7bddd-2c86-90e0-a8bf-0b322bb92bd9@loongson.cn>
On 02/09/2023 08:32, Jianmin Lv wrote:
> Each IRQ source of liointc may be routed to different IRQ source of
> cpuintc, for implementing this, bit mapping between liointc and cpuintc
> is required, and the mapping information is used for liointc IRQ routing
> register setting. It seems that interrupt-map can not pass the mapping
> to driver in current driver/of code, so the mapping is used in a
> non-standard way(of cause, underscore style may be changed in dts and
> driver).
>
> IMO, hardcode routing completely in driver is not flexible and not
"not recommended" by whom?
> recommended, and if possible, keep current map unchanged please.
>
You could have proposed that time, when review was happening. The
property was added AFTER review, so the review was invalidated.
Drop the property and use interrupt-map. Eventually change it to
something acceptable which will PASS review, not bypass it.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-09-04 7:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 6:13 Binbin Zhou
2023-08-22 4:44 ` Huacai Chen
2023-08-22 5:44 ` Krzysztof Kozlowski
2023-08-22 8:13 ` Binbin Zhou
2023-08-22 8:30 ` Krzysztof Kozlowski
2023-08-24 11:32 ` Binbin Zhou
2023-08-25 12:56 ` Krzysztof Kozlowski
2023-08-30 3:59 ` Jiaxun Yang
2023-08-30 13:44 ` Marc Zyngier
2023-08-30 15:25 ` Jiaxun Yang
2023-09-04 8:54 ` Marc Zyngier
2023-10-16 11:26 ` Binbin Zhou
2023-10-17 15:05 ` Jonas Gorski
2023-10-18 6:57 ` Binbin Zhou
2023-10-18 9:38 ` Jonas Gorski
2023-10-18 14:33 ` Huacai Chen
2023-10-20 9:51 ` Binbin Zhou
2023-10-20 12:18 ` Marc Zyngier
2023-10-25 1:56 ` Huacai Chen
2023-10-25 7:16 ` Krzysztof Kozlowski
2023-10-26 7:19 ` Huacai Chen
2023-10-29 7:42 ` Krzysztof Kozlowski
2023-10-30 9:56 ` Binbin Zhou
2023-08-30 14:35 ` Krzysztof Kozlowski
2023-08-30 15:31 ` Jiaxun Yang
2023-08-31 1:47 ` Binbin Zhou
2023-09-02 6:32 ` Jianmin Lv
2023-09-04 7:40 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc40c78-9d5a-ea23-586a-5cf38845bfaf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diasyzhang@tencent.com \
--cc=jiaxun.yang@flygoat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®