From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63A6D3B47FF for ; Mon, 8 Jun 2026 09:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780910460; cv=none; b=W/0OW6xFGxhxfCrteB1N9rYzoK0EZC0GF4gwTYuSO/s5SHUCE3BNEnkDPcIgFZIk3gtzzujEUbp4RRFT7WJXYccommZDmnk0BgqTxXHCUJLCqWSkTNfxmeEYkpayL0DGX2QpKtk05TjkvUBci2yP4TFYHtriabZS0O6+Zg/VsJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780910460; c=relaxed/simple; bh=V3ZB7tbh/dBJlzSpmCP9KFqGD72MYXvj7vP8C9/9tWE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j52/rganleocSnv98RwWgNosI+1ZJ9n29r14vUe1HO90VKczDPGl9qlkfjinSAK8roCoibQsP0xsMaOyeKL30qZ0DzimsUOvLaxggutWdjazuEkg/5riJrAkfpX14pEbJvgTq0gsiagVA4DAnykXoHDZ/M41ITcMetTzAMWKlCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n2BI9SLn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hrJDt6ou; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n2BI9SLn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hrJDt6ou" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586Oelw2385887 for ; Mon, 8 Jun 2026 09:20:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Dm76rGTSr3btxD4sk+JohwPzQz8nsVTx8rS21SkE/iw=; b=n2BI9SLni7ikwF5l 4FyToO9jutAaAsYms2egJWXPeBRwIBHpqdGz5w5yPNw/OS9fJFgfA7fq5WzkpS0M g17RchBt4lvPnkNFre05zDt9kDERh7im5BUBe5ketl3HgShcj+MKOOkku6onU7wN 7P5vDz+2TXRdh/RuNBlaANPGjZxCurbPI3UzyUmONPcYIUE9WaKwMcniL06aHmcY S+tQr6FFqiWXeIPX2E+W43tFDTzUX3j0T5I+uwelmXI9QJsDzyCnrSeS0lQaQrvu I8zU8IQul55tHSdCwAV1bYh/8x11AHmm+Af0KhijiRGDAs+enL6VFaDV9bGvkoBJ OjzLKg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4emcu8xv21-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 09:20:58 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51757324dcdso8070771cf.0 for ; Mon, 08 Jun 2026 02:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780910458; x=1781515258; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dm76rGTSr3btxD4sk+JohwPzQz8nsVTx8rS21SkE/iw=; b=hrJDt6ouObnNuUHWUs1NEGr9juyXhz9fNTZdOVwa3wyYw37SeTLJVXeMMAQ+zhe0cq 6MYcHzRzIIF9/h8AjQRj7huSumb2xV9PFfTWTgC1RN2bZbMhxl4UL2Q6nfimu0TO5Mcr MiNeC5t18F00LWwceAaEOPpPR/AW90osCIQZBOE1a6SzP684ut2LSijcwPwNfjIAClpQ dPYV0BiV8ekiRdL0BfTt5RaWKxJ+DfFrDFwdelIxNKXxYRHI51gyT5g9clnxPjiAqe7G y+cq9kOYDtsLu1um59Ul/fAVKzS3B2326AsuV4W2xOTrleFxD8BK4t8TATaShBr8x5bs pZCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780910458; x=1781515258; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dm76rGTSr3btxD4sk+JohwPzQz8nsVTx8rS21SkE/iw=; b=soinFU9mtdaJck+kkdAv/cZ4e8aTyLfoD4FndwYFz2LjWPCNTFx/eyJkdG/ssKo8fX u+Qe7TcQi5144VL1rOhmgzEtfNHmI1iKdi0zR7Ts16n683JSyuBxlbHI4sEWVRpme+xC QT+ppPPH/Ig+5nsGVBBYxLPSgFgDKH8fVha8ggbIeeAI6JmsUHuOzETkO0hvnkcDyTWj hZHiTVJKYgoNLFUjasQzlBheHkH//1QfrOCCbnrOXBzoNmrsinkCcrN7YUXu7nZG/D/w mSLpiF6x7RZ0mWaonX6mS6LT7kJBuVTbjGgNt3zDaILAnFSWrd/+O6DcJh6GZ5nEcE0G r16g== X-Forwarded-Encrypted: i=1; AFNElJ8HPARFqo8xtSQ+IiMH5mt5lWgXnggWfwI/Ol3W33CjvpULSQXXEyqDz2mkNcAHcfyEapO2Plb5xnVkqns=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp/ydjMWygUI9r3ire0uZTCh6vS5HiuRC8bub1itcbwqGOu0tG UTtUVR3yXAnbOZ0ZTfZ+RAVT4tahmEVd1MUIptyLdsB0XP5veuCIcczZuhwbITqdafuPI1WhsRG rh73MApoPheo0Va0IJRz9+MrFVF2iq5dA/TGvbQPAd4jaAh8ybR8mxDnPtzX5Bw9rNzw= X-Gm-Gg: Acq92OGGHZBTcT+Ur/wC16wS+mTpQlDGg9Fm2MNurTWuWJsnSpdQPAEechWu6Krmbdh otHI906LdjBciNA7DS0EgYg8P+iteDFp+J3/riiVkx7dTP6gbd36FIdqcarr5sEUGDvm9v9deEA ViO1qQLgic+EZQmrRtIA5zcPNLLpZYCcUaoVqD1Q8FiqDPO8Cm+TMg6CzQe8+oXtfQwz37sBnZE nxTkxmdiHDF97/ZVZkurGOujIABqjbwxo/PMCQNg0NB4fp6WLDWu7V+SydveXG+3yV8kit6hzOz 5EDu+493oN+BrgYfC23n6mjtqCmW659HsEY6nnV1YDUlyX5Zqx69UJShnfalnD6PGVpovqzPdL3 TWKX4slkVYK1IIgTTp9vHqV+LCbSdes3o4wyIvZyqLZMeipt6WPUGfOeC X-Received: by 2002:a05:622a:904:b0:50e:6311:7380 with SMTP id d75a77b69052e-51795c0d8bemr108304221cf.6.1780910457730; Mon, 08 Jun 2026 02:20:57 -0700 (PDT) X-Received: by 2002:a05:622a:904:b0:50e:6311:7380 with SMTP id d75a77b69052e-51795c0d8bemr108304061cf.6.1780910457279; Mon, 08 Jun 2026 02:20:57 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf051c8de00sm852347366b.20.2026.06.08.02.20.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 02:20:56 -0700 (PDT) Message-ID: <8bcdc105-4393-45e4-acc8-0faae3ceaeba@oss.qualcomm.com> Date: Mon, 8 Jun 2026 11:20:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] clk: qcom: gdsc: add LEGACY_FOOTSWITCH support for MSM8x60 To: Dmitry Baryshkov , Herman van Hazendonk Cc: Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260606-submit-clk-gdsc-msm8x60-legacy-v2-0-187a32d2f015@herrie.org> <20260606-submit-clk-gdsc-msm8x60-legacy-v2-1-187a32d2f015@herrie.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: UJHuvLpUui6xZC7j3yYS9kQw1yaRUKkR X-Authority-Analysis: v=2.4 cv=deGwG3Xe c=1 sm=1 tr=0 ts=6a26897a cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=ISS9l3P2gTKgTzszIxwA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA4NiBTYWx0ZWRfX9v2VC/gJgKQ3 xnWre6M6TKn1QraKgqTOFSrpeAuH6CRR21wWgFyabehbB+BDI8DZaky84Y4IK3wNg/to3iBXg/n f8ucbEnEprc/r4edd6+dUZtcPEic7CbRnhrsRCPlmOlAwKxjZeASrMfd50BJAQqcG3eRwflh6vf 1q9UD5/virHXb2Qux8dldDUyGV+5Iadc+KZnlAZxaawql9sm+X9txYJJ7Nx/c4iTqL/7+Mz9OtE R8rtbiakWoKXDcjuevns1mswjCrVPKRfz1XbsL66jcd2nVgafiLrqz52rNor2UQuJ6Ntv6u80c+ M0GKVFQKwk7MwvoVIeI9yP7HzR+47xEh9FEGanWROpN9mbsol1xRyhV4Bn+VhHJR+flGVkSxo1Z JmgmgF2o7+oiQyi0UE1OWu1/mMNJDbljubGZ5inuPRftxyO1HlXUPxVg6ZxsS8S1dtJxNIqTPL2 Y/lMJU2Yw7QfsUyaXKQ== X-Proofpoint-GUID: UJHuvLpUui6xZC7j3yYS9kQw1yaRUKkR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080086 On 6/6/26 5:17 PM, Dmitry Baryshkov wrote: > On Sat, Jun 06, 2026 at 02:34:26PM +0200, Herman van Hazendonk wrote: >> The MSM8x60 family (MSM8260, MSM8660, APQ8060) ships an older >> footswitch (FS / "GFS") block that pre-dates the GDSC programming >> model the existing driver was designed around. Adding GDSC entries >> for that family's MMCC power domains needs the driver to understand >> the legacy register layout: >> >> - the CLAMP, ENABLE and RETENTION bits live in the main GDSCR >> register rather than in a separate clamp_io_ctrl; >> - there is no power-status bit, so software cannot poll for the >> transition completing and has to gate progress on a fixed >> udelay() after toggling ENABLE; >> - ENABLE is positive-logic (set to power up, clear to collapse) >> rather than the modern inverted SW_COLLAPSE semantics; >> - none of the modern wait-time / HW-trigger / SW-override fields >> are present, so gdsc_init() must skip the wait-config >> programming block entirely. > > I think there are enough differences to mandate a separate footswitch.c > file. It can further be used by MMCC on MSM8960 and APQ8064 platforms. > It might result by some code duplication, but I think in the end it > would be easier to read (and it won't clobber the existing gdsc.c code). Yes please, gdsc.c is already a bit convoluted.. Konrad