mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Imran Shaik <quic_imrashai@quicinc.com>
To: Taniya Das <taniya.das@oss.qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Taniya Das <quic_tdas@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Ajit Pandey <quic_ajipan@quicinc.com>,
	Jagadeesh Kona <quic_jkona@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615: Add CPU scaling clock node
Date: Tue, 17 Jun 2025 12:59:00 +0530	[thread overview]
Message-ID: <8bceae03-33fe-4ec0-b1da-785af793dd86@quicinc.com> (raw)
In-Reply-To: <89536376-6619-49a5-a267-b5a6b98940d8@oss.qualcomm.com>



On 6/17/2025 12:27 PM, Taniya Das wrote:
> 
> 
> On 6/13/2025 6:40 PM, Dmitry Baryshkov wrote:
>> On Thu, Jun 12, 2025 at 03:47:21PM +0530, Taniya Das wrote:
>>> Add cpufreq-hw node to support CPU frequency scaling.
>>>
>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/qcs615.dtsi | 29 +++++++++++++++++++++++++++++
>>>  1 file changed, 29 insertions(+)
>>>
>>> +
>>> +		cpufreq_hw: cpufreq@18323000 {
>>> +			compatible = "qcom,sc7180-cpufreq-hw", qcom,cpufreq-hw";
>>
>> This wasn't build-tested (or was edited after being compile-tested).
> 
> This is already tested on the QCS615.
>>

Seems there is a syntax issue, could you please check?
 
- compatible = "qcom,sc7180-cpufreq-hw", qcom,cpufreq-hw";
+ compatible = "qcom,sc7180-cpufreq-hw", "qcom,cpufreq-hw";

>>> +			reg = <0 0x18323000 0 0x1400>, <0 0x18325800 0 0x1400>;
>>> +			reg-names = "freq-domain0", "freq-domain1";
>>> +
>>> +			clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GPLL0>;
>>> +			clock-names = "xo", "alternate";
>>> +
>>> +			#freq-domain-cells = <1>;
>>> +			#clock-cells = <1>;
>>> +		};
>>> +
>>>  	};
>>>  
>>>  	arch_timer: timer {
>>>
>>> -- 
>>> 2.34.1
>>>
>>
> 


  reply	other threads:[~2025-06-17  7:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 10:17 [PATCH v3 0/2] Add support for clock controllers and CPU scaling for QCS615 Taniya Das
2025-06-12 10:17 ` [PATCH v3 1/2] arm64: dts: qcom: qcs615: Add clock nodes for multimedia clock Taniya Das
2025-06-12 10:17 ` [PATCH v3 2/2] arm64: dts: qcom: qcs615: Add CPU scaling clock node Taniya Das
2025-06-13 13:10   ` Dmitry Baryshkov
2025-06-17  6:57     ` Taniya Das
2025-06-17  7:29       ` Imran Shaik [this message]
2025-06-17  8:39         ` Taniya Das
2025-06-17 12:58           ` Dmitry Baryshkov
2025-06-12 20:12 ` [PATCH v3 0/2] Add support for clock controllers and CPU scaling for QCS615 Rob Herring (Arm)
2025-06-18 21:21 ` Bjorn Andersson
2025-06-25 10:51   ` Taniya Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bceae03-33fe-4ec0-b1da-785af793dd86@quicinc.com \
    --to=quic_imrashai@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=taniya.das@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®