From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1750978AbXCERJW@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750978AbXCERJW (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Mar 2007 12:09:22 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751014AbXCERJW
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 5 Mar 2007 12:09:22 -0500
Received: from an-out-0708.google.com ([209.85.132.248]:61322 "EHLO
	an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750869AbXCERJV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Mar 2007 12:09:21 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=lSgSWS1QAZ6JVU0kXyzA9DvRjcUsy4Ymh3wqSsKNa88zmJq4DSjNqgqyJVH+ZRaC8FyP9XRy01duvRHUgSQI5cwn45qHKnI+P6HnvANcXhkhTibSQCXWow+CmJ+jw9qKfYM332e0mTrZp9gM/EEPFzopBi+4ubA7qT/ebeWkuYo=
Message-ID: <8bd0f97a0703050909n18386114kd2c0b2a108591641@mail.gmail.com>
Date: Mon, 5 Mar 2007 12:09:20 -0500
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
       linux-serial@vger.kernel.org, "Robin Getz" <rgetz@blackfin.uclinux.org>
Subject: Re: should RTS init in serial core be tied to CRTSCTS
In-Reply-To: <20070304194632.GC30345@flint.arm.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <8bd0f97a0703011603m794e00f5x875eb68ad0db05de@mail.gmail.com>
	 <20070304194632.GC30345@flint.arm.linux.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/4/07, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> On Thu, Mar 01, 2007 at 07:03:02PM -0500, Mike Frysinger wrote:
> > the console= bootcmd allows for controlling of the initial state of
> > flow control by adding/omitting the 'r' suffix ...
>
> The console command *only* sets the state for the kernel's use of one
> serial port.  It does not affect any other serial port, so tying
> random RTS behaviours into that command line option is absolutely
> silly.

true ... so ignoring the original motivation for change i posted, is
it really correct for the serial core to be forcing TIOCM_RTS at uart
startup even though the uart doesnt have CTSRTS flow control enabled ?
 in other words, my change is agnostic of the console, and is done for
all uarts ... it should prob have a similar change in uart_shutdown()
though ...
-mike