From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Paul Mundt" <lethal@linux-sh.org>,
"Mike Frysinger" <vapier.adi@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Bryan Wu" <Bryan.Wu@analog.com>
Subject: Re: how to allow board writers to customize driver behavior (watchdog here)
Date: Thu, 24 May 2007 11:12:46 -0400 [thread overview]
Message-ID: <8bd0f97a0705240812s27925cads9b2f50dbeb67b9ff@mail.gmail.com> (raw)
In-Reply-To: <20070524052312.GA2447@linux-sh.org>
On 5/24/07, Paul Mundt <lethal@linux-sh.org> wrote:
> On Thu, May 24, 2007 at 12:21:47AM -0400, Mike Frysinger wrote:
> > is this completely bad mojo ? is there some other mechanism that
> > provides what i want and i just dont know about it ? or do i just
> > make people change the driver to fit their application, thus throwing
> > out the idea of keeping all board-specific details in just the boards
> > file ...
>
> It sounds like your constraining your driver based on terminology.
> Watchdogs on most embedded platforms support either a 'reset' mode or
> otherwise act as periodic timers, trying to push both of these
> functionalities in to a watchdog driver is rather pointless.
> CONFIG_WATCHDOG implies 'reset' mode by definition.
my constraint was trying to keep all of the code that deals with the
watchdog in one file ... those were the blinders i had on from the get
go so the idea of having different drivers that work with the watchdog
hardware hadnt even occurred to me
> If you wish to use your watchdog timer as a periodic timer, simply have a
> clocksource/clockevents established for it, leave the watchdog driver as
> a reset-only thing, and let the user decide which one they want either
> via Kconfig or the kernel command line. (The watchdog driver can just
> -ENODEV or -EBUSY if the clocksource is active).
hmm, i'll poke the clocksource/clockevents stuff as well as the
notifier idea from Alan
thanks
-mike
next prev parent reply other threads:[~2007-05-24 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 4:21 Mike Frysinger
2007-05-24 5:23 ` Paul Mundt
2007-05-24 8:47 ` Daniel Newby
2007-05-24 9:32 ` Paul Mundt
2007-05-24 15:08 ` Mike Frysinger
2007-05-24 13:29 ` Robin Getz
2007-05-24 15:23 ` Paul Mundt
2007-05-24 17:32 ` Robin Getz
2007-05-25 4:04 ` Paul Mundt
2007-05-25 10:09 ` Daniel Newby
2007-05-25 17:55 ` Mike Frysinger
2007-05-24 15:12 ` Mike Frysinger [this message]
2007-05-24 10:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0705240812s27925cads9b2f50dbeb67b9ff@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=Bryan.Wu@analog.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®