From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: "Sonic Zhang" <sonic.adi@gmail.com>,
"Linux IDE" <linux-ide@vger.kernel.org>,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
"Bryan Wu" <bryan.wu@analog.com>
Subject: Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.
Date: Thu, 16 Aug 2007 12:27:05 -0400 [thread overview]
Message-ID: <8bd0f97a0708160927s625fd5ax84cd6d12a693d9ad@mail.gmail.com> (raw)
In-Reply-To: <46C3F6FB.2070909@garzik.org>
On 8/16/07, Jeff Garzik <jeff@garzik.org> wrote:
> Sonic Zhang wrote:
> > +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev)
> > +{
> > + int mode = adev->pio_mode - XFER_PIO_0;
> > + unsigned long base = (unsigned long)ap->ioaddr.ctl_addr;
>
>
> (added Bryan Wu to CC)
>
> Someone needs to need fix the bfin architecture: the addresses on the
> bfin_read/bfin_write functions should be 'void __iomem *' not unsigned long.
there are no address pointers anymore, so there is nothing to cast ...
the bfin_read/bfin_write macros are done in sexy asm:
#define bfin_write8(addr,val) __asm__ __volatile__("b[%0] = %1;" ::
"a"(addr), "d"(val))
or i'm misunderstanding what you mean ...
where do you see (unsigned long) ?
-mike
next prev parent reply other threads:[~2007-08-16 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 9:14 Sonic Zhang
2007-08-15 10:06 ` Alan Cox
2007-08-16 7:04 ` Jeff Garzik
2007-08-16 16:27 ` Mike Frysinger [this message]
2007-08-16 18:40 ` Jeff Garzik
2007-08-16 18:46 ` Mike Frysinger
2007-08-16 18:56 ` Jeff Garzik
2007-08-17 2:18 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0708160927s625fd5ax84cd6d12a693d9ad@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=bryan.wu@analog.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sonic.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®