From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Jie Zhang" <jie.zhang@analog.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Add a new field `name' to struct linux_binfmt
Date: Thu, 16 Aug 2007 14:28:43 -0400 [thread overview]
Message-ID: <8bd0f97a0708161128g71ca385ak6ddcb1b36d7fabc2@mail.gmail.com> (raw)
In-Reply-To: <1187248823.11475.24.camel@mercury.analog.com>
On 8/16/07, Jie Zhang <jie.zhang@analog.com> wrote:
> This patch addes a new `name' field to struct linux_binfmt and
> initialize it in each binfmt type.
>
> A second blackfin arch patch will use this field to distinguish `flat'
> binfmt with `FDPIC ELF'.
>
> Is it OK? Any comments?
the other possibility would be to not make linux_binfmt definitions
static and put appropriate prototypes in the fs.h header ... then you
could do:
if (current->binfmt == aout_format) {
... aout stuff ...
}
then again, this goes against the dynamic nature of the binfmt itself
... and the idea that the binfmt should not matter to anything else in
the kernel once it's executing ...
-mike
next prev parent reply other threads:[~2007-08-16 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 7:20 Jie Zhang
2007-08-16 18:28 ` Mike Frysinger [this message]
2007-08-16 19:24 ` Alexey Dobriyan
2007-08-16 19:39 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0708161128g71ca385ak6ddcb1b36d7fabc2@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=jie.zhang@analog.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®