From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Andy Whitcroft" <apw@shadowen.org>
Cc: "Mike Frysinger" <vapier@gentoo.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
bryan.wu@analog.com
Subject: Re: [patch] add some Blackfin specific checks to checkpatch.pl
Date: Thu, 13 Sep 2007 11:33:02 -0400 [thread overview]
Message-ID: <8bd0f97a0709130833g7873ed03m2eff4318a0e4a3e2@mail.gmail.com> (raw)
In-Reply-To: <20070913115521.GB5146@shadowen.org>
On 9/13/07, Andy Whitcroft <apw@shadowen.org> wrote:
> On Tue, Aug 21, 2007 at 06:29:59PM -0400, Mike Frysinger wrote:
> > Check for a few common errors in Blackfin-specific code wrt MMR loading in
> > assembly and doing core/system syncs.
>
> If we are going to pull arch specific things into checkpatch I think we
> need to make sure we are pretty specific about where we apply them. I
> am assuming these checks only make sense againt some files in the arch
> tree?
ive restricted the .S check to arch/blackfin/, but the other check
should be run on all .c files since Blackfin drivers may live anywhere
in the tree, not just in arch/ ... i really doubt that'd be a problem
unless another architecture starts implementing functions with
"__builtin_bfin_ssync" in its name ...
side note, Joe pointed out that arch/blackfin regex should be m@...@, not s@...@
-mike
prev parent reply other threads:[~2007-09-13 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 22:29 Mike Frysinger
2007-08-22 2:15 ` Mike Frysinger
2007-09-13 11:55 ` Andy Whitcroft
2007-09-13 15:33 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0709130833g7873ed03m2eff4318a0e4a3e2@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome