mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Adrian Bunk" <bunk@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	"Jie Zhang" <jzhang.linux@gmail.com>,
	bryan.wu@analog.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] blackfin: "extern inline" -> "static inline"
Date: Thu, 25 Oct 2007 12:16:40 -0400	[thread overview]
Message-ID: <8bd0f97a0710250916v5d3f0166qbfacf4abb0fc3d45@mail.gmail.com> (raw)
In-Reply-To: <20071025150545.GK30533@stusta.de>

On 10/25/07, Adrian Bunk <bunk@kernel.org> wrote:
> On Wed, Oct 24, 2007 at 08:06:14PM -0700, H. Peter Anvin wrote:
> > Mike Frysinger wrote:
> >> we'll have to either use the gcc attributes to force old inline
> >> behavior or use the gcc flag to force it
> >
> > We should probably have an extern_inline define then, assuming this is a
> > function that does exist in a linkable version already -- otherwise "static
> > inline" is correct.
>
> Since we #define inline to be __attribute__((always_inline))
> "extern inline" with the old semantics would only behave differently
> if someone took the address of one of these string functions.

that isnt what we intended ;)

> Does this happen anywhere in the blackfin port?

gcc is also free to ignore the optimized inline in favor of an
external reference
-mike

  reply	other threads:[~2007-10-25 16:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24 16:26 Adrian Bunk
2007-10-25  2:47 ` Jie Zhang
2007-10-25  3:00   ` Mike Frysinger
2007-10-25  3:06     ` H. Peter Anvin
2007-10-25  3:17       ` Mike Frysinger
2007-10-25 15:05       ` Adrian Bunk
2007-10-25 16:16         ` Mike Frysinger [this message]
2007-10-25 16:53           ` Adrian Bunk
2007-10-25 20:07             ` Mike Frysinger
2007-10-25 20:18               ` Adrian Bunk
2007-10-25 20:20                 ` Mike Frysinger
2007-10-25 20:28                   ` H. Peter Anvin
2007-10-25 20:45                     ` Mike Frysinger
2007-10-25 20:53                       ` H. Peter Anvin
2007-10-25 20:47                     ` Adrian Bunk
2007-10-25 20:54                       ` H. Peter Anvin
2007-10-25 20:46                   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0710250916v5d3f0166qbfacf4abb0fc3d45@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=bryan.wu@analog.com \
    --cc=bunk@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jzhang.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®