From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760201AbXJYUpS (ORCPT ); Thu, 25 Oct 2007 16:45:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753606AbXJYUpF (ORCPT ); Thu, 25 Oct 2007 16:45:05 -0400 Received: from rv-out-0910.google.com ([209.85.198.186]:57688 "EHLO rv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbXJYUpC (ORCPT ); Thu, 25 Oct 2007 16:45:02 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=XUnHunhP9inKhCu4slXMLyzP3luJe7MuV5Gr/JH6d8DNRtOAXSmU0XWhShtk9ygzdz5k4vfmXH4WvWCH2FtDmljfPajWigBmKAZfvYXdTuSueQaogntlkQKqVOgpHLp6s6pR65Ct1dUjWfq+F4/wZ9nz0keT7uyTKVkCaBBMeRU= Message-ID: <8bd0f97a0710251345t6e50bcd3u11be001ee900d9cf@mail.gmail.com> Date: Thu, 25 Oct 2007 16:45:01 -0400 From: "Mike Frysinger" To: "H. Peter Anvin" Subject: Re: [2.6 patch] blackfin: "extern inline" -> "static inline" Cc: "Adrian Bunk" , "Jie Zhang" , bryan.wu@analog.com, linux-kernel@vger.kernel.org In-Reply-To: <4720FC54.1020705@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071024162643.GP30533@stusta.de> <8bd0f97a0710242000h7b6c97e7ia3f461c69b7d5de5@mail.gmail.com> <47200826.1060801@zytor.com> <20071025150545.GK30533@stusta.de> <8bd0f97a0710250916v5d3f0166qbfacf4abb0fc3d45@mail.gmail.com> <20071025165344.GL30533@stusta.de> <8bd0f97a0710251307m9f45f4dmf6d8cfa93af9fdf5@mail.gmail.com> <20071025201842.GT30533@stusta.de> <8bd0f97a0710251320m3490c53dpe85656a939e8536e@mail.gmail.com> <4720FC54.1020705@zytor.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/07, H. Peter Anvin wrote: > Mike Frysinger wrote: > >> Do you have any example for your claim "to get gcc to not inline things > >> when building debug versions"? > > > > $ cat test.c > > __attribute__((always_inline)) int foo(void) { return 0; } > > int main(void){ return foo(); } > > $ gcc -g test.c -o test > > $ readelf -s test | grep FUNC | grep -v _ > > 61: 00000000004004b8 11 FUNC GLOBAL DEFAULT 13 foo > > 68: 00000000004004c3 11 FUNC GLOBAL DEFAULT 13 main > > > > looks pretty straightforward to me > > For "debug version" meaning -O0, this is true. which is what i meant, sorry for not being more clear anyways, this is all moot ... we dont want "always inline" nor do we want "static inline" for our string functions. we want the classical GNU meaning of "extern inline" which means we're going to either have a Blackfin specific "extern_inline" define or we get one added to the common compiler headers and use that. Peter (or is it "H. Peter" ?): you going to post a patch or should i ? -mike