From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Sam Ravnborg" <sam@ravnborg.org>
Cc: "Cyrill Gorcunov" <gorcunov@gmail.com>,
linux-kernel@vger.kernel.org, davem@davemloft.net,
bryan.wu@analog.com, hskinnemoen@atmel.co, dhowells@redhat.com
Subject: Re: [patch 0/4] cleanup - use _AC macro to define PAGE_SIZE
Date: Mon, 4 Feb 2008 15:01:30 -0500 [thread overview]
Message-ID: <8bd0f97a0802041201w326404b6j25c20951ee35b0b6@mail.gmail.com> (raw)
In-Reply-To: <20080203122239.GF20810@uranus.ravnborg.org>
On Feb 3, 2008 7:22 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Sun, Feb 03, 2008 at 02:22:17PM +0300, Cyrill Gorcunov wrote:
> > This patch series removes code duplication for PAGE_SIZE
> > definition on various architectures.
> >
> > Please review. Any comments are welcome. *UNTESTED*
>
> Looks good.
> Could you do a followup patch for each architecture introducing
> use of PAGE_SIZE in their respective kernel/vmlinux.lds.S too?
> I think more than your 4 listed architectures could need this fix.
what did you have in mind exactly ? afaik, the Blackfin linker script
should already be friendly wrt using defines instead of hardcoded
constants ...
-mike
next prev parent reply other threads:[~2008-02-04 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 11:22 Cyrill Gorcunov
2008-02-03 12:22 ` Sam Ravnborg
2008-02-03 12:40 ` Cyrill Gorcunov
2008-02-03 13:07 ` Cyrill Gorcunov
2008-02-04 20:01 ` Mike Frysinger [this message]
2008-02-04 20:28 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0802041201w326404b6j25c20951ee35b0b6@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=bryan.wu@analog.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=gorcunov@gmail.com \
--cc=hskinnemoen@atmel.co \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®