mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Jiri Slaby" <jirislaby@gmail.com>
Cc: "Bryan Wu" <bryan.wu@analog.com>,
	linux-kernel@vger.kernel.org,
	"Mike Frysinger" <michael.frysinger@analog.com>
Subject: Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory
Date: Tue, 5 Feb 2008 13:59:52 -0500	[thread overview]
Message-ID: <8bd0f97a0802051059kb108412x7285ebbf82342d48@mail.gmail.com> (raw)
In-Reply-To: <47A058B3.6000009@gmail.com>

On Jan 30, 2008 6:00 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
> On 01/30/2008 11:36 AM, Bryan Wu wrote:
> > +
> > +     ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1);
> > +     if (ret) {
> > +             unregister_chrdev_region(bfin_otp_dev_node, 1);
> > +             printk(KERN_ERR PFX "unable to register char device\n");
> > +             return ret;
> > +     }
> > +
> > +     bfin_otp_class = class_create(THIS_MODULE, "otp");
> > +     device_create(bfin_otp_class, NULL, bfin_otp_dev_node, "otp");
>
> Anyway, wouldn't be easier/better to use misc.c functionality here
> (misc_register() et al.)?

thanks, ive converted this now ... Bryan can post an updated patch :)
http://blackfin.uclinux.org/gf/project/linux-kernel/scmsvn/?action=browse&path=/trunk/drivers/char/bfin-otp.c&r1=4224&r2=4223
-mike

      parent reply	other threads:[~2008-02-05 19:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 10:36 Bryan Wu
2008-01-30 11:00 ` Jiri Slaby
2008-01-30 12:39   ` Robin Getz
2008-01-30 13:08     ` Jiri Slaby
2008-01-30 13:15     ` Bryan Wu
2008-01-30 13:43       ` Jiri Slaby
2008-01-30 13:53         ` Jiri Slaby
2008-01-30 13:19   ` Mike Frysinger
2008-01-30 13:38     ` Jiri Slaby
2008-01-30 13:41       ` Mike Frysinger
2008-02-05 18:59   ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0802051059kb108412x7285ebbf82342d48@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=bryan.wu@analog.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.frysinger@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®