From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Sam Ravnborg" <sam@ravnborg.org>
Cc: "Jiri Slaby" <jirislaby@gmail.com>,
"Bryan Wu" <cooloney@kernel.org>,
linux-kernel@vger.kernel.org, "Wim Van Sebroeck" <wim@iguana.be>
Subject: Re: [PATCH 1/1] [Blackfin try #2] char driver for Blackfin on-chip OTP memory
Date: Wed, 26 Mar 2008 17:12:53 -0400 [thread overview]
Message-ID: <8bd0f97a0803261412t1b6fd2c7nef86d56a49994c3c@mail.gmail.com> (raw)
In-Reply-To: <20080326210819.GC24954@uranus.ravnborg.org>
On Wed, Mar 26, 2008 at 5:08 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Wed, Mar 26, 2008 at 03:14:14PM -0400, Mike Frysinger wrote:
> > On Wed, Mar 26, 2008 at 3:09 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> > > > > > also, it isnt "broken" in the sense that it "doesnt work" ;)
> > > > >
> > > > > Gcc simply doesn't allow that, you likely got 2 sections with init.data, with
> > > > > and without readonly bit set, which is wrong, and it seems, that on some systems
> > > > > (debian) you won't even compile it.
> > > >
> > > > gcc-4.1.2/binutils-2.17 doesnt have a problem compiling/linking the
> > > > code in question. and i imagine i would have noticed a build/link
> > > > failure long before testing it on actual hardware.
> > >
> > > target arch dependent. Try with 64 bit powerpc.
> >
> > this code appears in drivers that are for Blackfin-specific pieces of
> > hardware. it may fail to build on
> > some-random-arch-that-isnt-Blackfin, but if it works for Blackfin,
> > what do the other arches realistically matter ?
> >
> > yes, the code will get changed as suggested as it is the right thing
> > to do, it just isnt a real problem today.
>
> It is a real problem for build monkeys (like me sometimes) if
> an allyesconfig suddenly does not build.
it isnt a problem at all considering the next part:
> If this driver can be build for other than blackfin I do not
> know.
it's a device driver for hardware on the Blackfin processor itself.
the Kconfig has "depends on BLACKFIN". it just aint gonna be an issue
:).
-mike
prev parent reply other threads:[~2008-03-26 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 1:08 Bryan Wu
2008-03-26 10:33 ` Jiri Slaby
2008-03-26 14:31 ` Mike Frysinger
2008-03-26 18:34 ` Jiri Slaby
2008-03-26 18:40 ` Mike Frysinger
2008-03-26 19:09 ` Sam Ravnborg
2008-03-26 19:14 ` Mike Frysinger
2008-03-26 21:08 ` Sam Ravnborg
2008-03-26 21:12 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0803261412t1b6fd2c7nef86d56a49994c3c@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cooloney@kernel.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®