From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758030AbYELLme (ORCPT ); Mon, 12 May 2008 07:42:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751488AbYELLmZ (ORCPT ); Mon, 12 May 2008 07:42:25 -0400 Received: from wf-out-1314.google.com ([209.85.200.168]:18061 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbYELLmY (ORCPT ); Mon, 12 May 2008 07:42:24 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=vZqNDCvdE051M6fy1vtmsqdlqwjKVgU84WcrnNXKeDIDtSoqPFJAUHuP4R29Rral6G1AgDX2VOgJNLl48w846SxVWDnQkWXw8OdA1Ir5KlF0O9qVsosCwDBKqpmKl4S8bdSPa1EpBSnfUVSXZ+Y6HP9bbZvrOA4B6f8p/BTIXhM= Message-ID: <8bd0f97a0805120442j3875b58bwab3959fdb3de9db2@mail.gmail.com> Date: Mon, 12 May 2008 07:42:23 -0400 From: "Mike Frysinger" To: "pHilipp Zabel" Subject: Re: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver Cc: "Bryan Wu" , dbrownell@users.sourceforge.net, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, "Michael Hennerich" In-Reply-To: <74d0deb30805120427x71b4588es9200f80252bab319@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1210587437-9751-1-git-send-email-cooloney@kernel.org> <74d0deb30805120427x71b4588es9200f80252bab319@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 12, 2008 at 7:27 AM, pHilipp Zabel wrote: > On Mon, May 12, 2008 at 12:17 PM, Bryan Wu wrote: >> From: Michael Hennerich >> >> It's an actual deficiency in the hardware that we can't address, >> so it needs to be worked around in software. >> >> Signed-off-by: Michael Hennerich >> Signed-off-by: Bryan Wu >> --- >> drivers/input/keyboard/gpio_keys.c | 15 ++++++++++++++- >> 1 files changed, 14 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c >> index bbd00c3..d856eb9 100644 >> --- a/drivers/input/keyboard/gpio_keys.c >> +++ b/drivers/input/keyboard/gpio_keys.c >> @@ -26,6 +26,18 @@ >> >> #include >> >> +#if defined(CONFIG_BLACKFIN) && !defined(BF548_FAMILY) >> + >> +/* >> + * On some Blackfin CPUs reading edge triggered >> + * GPIOs doesn't return the current value >> + */ > > If this is a generic problem, shouldn't this be addressed inside gpio_get_value? it's an issue only when the GPIO is an interrupt source and the trigger condition is set to both rising and falling. but i guess your point is that in gpio_get_value(), we can check to see if these conditions are met and if so, temporarily fiddle things there ? Michael: that sounds reasonable, what do you think ? -mike