From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Bryan Wu" <cooloney@kernel.org>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/3] Blackfin EMAC Driver: add proper __devinit/__devexit markings
Date: Sun, 27 Jul 2008 09:03:27 -0400 [thread overview]
Message-ID: <8bd0f97a0807270603s2d3ac6f7q3735b2ac6e31a22c@mail.gmail.com> (raw)
In-Reply-To: <1217139235-19018-2-git-send-email-cooloney@kernel.org>
On Sun, Jul 27, 2008 at 2:13 AM, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@gmail.com>
>
> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
> drivers/net/bfin_mac.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
> index 4144343..e18a7ee 100644
> --- a/drivers/net/bfin_mac.c
> +++ b/drivers/net/bfin_mac.c
> @@ -614,7 +614,7 @@ static int bfin_mac_hard_start_xmit(struct sk_buff *skb,
> * Is skb->data always 16-bit aligned?
> * Do we need to memcpy((char *)(tail->packet + 2), skb->data, len)?
> */
> - if ((((unsigned int)(skb->data)) & 0x02) == 2) {
> + if ((((unsigned int)(skb->data)) & 0x01) == 0) {
> /* move skb->data to current_tx_ptr payload */
> data = (unsigned int)(skb->data) - 2;
> *((unsigned short *)data) = (unsigned short)(skb->len);
i think this unrelated hunk slipped in
-mike
next prev parent reply other threads:[~2008-07-27 13:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 6:13 [PATCH 0/3] Blackfin EMAC Driver updates for 2.6.27 Bryan Wu
2008-07-27 6:13 ` [PATCH 1/3] Blackfin EMAC Driver: add proper __devinit/__devexit markings Bryan Wu
2008-07-27 13:03 ` Mike Frysinger [this message]
2008-07-27 14:46 ` Bryan Wu
2008-07-27 6:13 ` [PATCH 2/3] Blackfin EMAC Driver: enable TXDWA new feature for new silicon (rev > 0.2) Bryan Wu
2008-07-28 10:05 ` Ingo Oeser
2008-07-27 6:13 ` [PATCH 3/3] Blackfin EMAC Driver: Functional power management support Bryan Wu
2008-07-27 14:45 [PATCH 0/3] Blackfin EMAC Driver updates for 2.6.27 (v2) Bryan Wu
2008-07-27 14:45 ` [PATCH 1/3] Blackfin EMAC Driver: add proper __devinit/__devexit markings Bryan Wu
2008-07-28 15:21 ` Paulius Zaleckas
2008-07-29 3:34 ` Bryan Wu
2008-07-29 21:49 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0807270603s2d3ac6f7q3735b2ac6e31a22c@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®