From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Yoshinori Sato" <ysato@users.sourceforge.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blackfin / h8300 build error fix
Date: Wed, 30 Jul 2008 23:51:43 -0400 [thread overview]
Message-ID: <8bd0f97a0807302051u22f49e1fp773cb468494d5fcb@mail.gmail.com> (raw)
In-Reply-To: <20080730203741.4d7df2ad.akpm@linux-foundation.org>
On Wed, Jul 30, 2008 at 11:37 PM, Andrew Morton wrote:
> On Wed, 30 Jul 2008 23:26:47 -0400 "Mike Frysinger" wrote:
>> you cant just use straight symbol names in common header files as they
>> dont take into consideration weird arch-specific ABI conventions. in
>> the case of Blackfin/h8300, the ABI dictates that any C-visible
>> symbols have an underscore prefixed to them. thus all symbols in
>> vmlinux.lds.h need to be wrapped in VMLINUX_SYMBOL() so that each arch
>> can put hide this magic in their own files.
>
> ooh, a changelog.
>
> This seems to be a pretty common failing. I just had to fix the same
> problem in a linux-next patch:
PERCPU is broken in mainline currently as well ... but it looks like
there's extended stuff in linux-next now
> It's going to keep happening too, unless we find some way of making x86
> break when people forget to use VMLINUX_SYMBOL().
i pondered it briefly when i saw Yoshinori's original e-mail, but
nothing pretty came to mind
-mike
prev parent reply other threads:[~2008-07-31 3:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 15:58 Yoshinori Sato
2008-07-30 16:11 ` Mike Frysinger
2008-07-30 19:22 ` Yoshinori Sato
2008-07-30 20:01 ` Andrew Morton
2008-07-31 0:26 ` [PATCH] Missing symbol prefix on vmlinux.lds.h Yoshinori Sato
2008-07-31 2:06 ` Andrew Morton
2008-07-31 3:20 ` Yoshinori Sato
2008-07-31 3:26 ` [PATCH] blackfin / h8300 build error fix Mike Frysinger
2008-07-31 3:37 ` Andrew Morton
2008-07-31 3:51 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0807302051u22f49e1fp773cb468494d5fcb@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®