From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763379AbYHFMPW (ORCPT ); Wed, 6 Aug 2008 08:15:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752866AbYHFMOt (ORCPT ); Wed, 6 Aug 2008 08:14:49 -0400 Received: from wf-out-1314.google.com ([209.85.200.175]:15984 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbYHFMOs (ORCPT ); Wed, 6 Aug 2008 08:14:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=m1+VCEqiT+LrL+IX578GB0Ix7EY0R7DiWHyno3Ufx3oUfR9mLz1wbjVM9/in5WTskM OZyoyofkFV9r9YJ6OMn5iGNlO31FdM94ik0I5gHrUZJwlKUQWUnU+biGRg067TlwQUMq ONPpd6CXpgneVq9i/dAJ5iPJJXRctMFuHk93A= Message-ID: <8bd0f97a0808060514x5c9ed37exbf8f9852b5a0b55d@mail.gmail.com> Date: Wed, 6 Aug 2008 08:14:47 -0400 From: "Mike Frysinger" To: "Vegard Nossum" Subject: Re: [PATCH] blackfin/sram: use 'unsigned long' for irqflags Cc: "Bryan Wu" , "Julia Lawall" , "Alexey Dobriyan" , linux-kernel@vger.kernel.org In-Reply-To: <19f34abd0808060428m1c317531v4a58679c4051c0e9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080806105836.GA2903@localhost.localdomain> <8bd0f97a0808060405qf70ead2t2f2604802875197e@mail.gmail.com> <19f34abd0808060428m1c317531v4a58679c4051c0e9@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 6, 2008 at 7:28 AM, Vegard Nossum wrote: > On Wed, Aug 6, 2008 at 1:05 PM, Mike Frysinger wrote: >> On Wed, Aug 6, 2008 at 6:58 AM, Vegard Nossum wrote: >>> From 3ef36948a88a968eec1b09859aa251dc6727df4e Mon Sep 17 00:00:00 2001 >>> From: Vegard Nossum >>> Date: Wed, 6 Aug 2008 12:00:23 +0200 >>> Subject: [PATCH] blackfin/sram: use 'unsigned long' for irqflags >>> >>> Using just 'unsigned' will make flags an unsigned int. While this is >>> arguably not an error on blackfin where sizeof(int) == sizeof(long), >>> the patch is still justified on the grounds of principle. >> >> indeed, thanks >> >>> The patch was generated using the Coccinelle semantic patch framework. >> >> spam ? > > Hm? I'm sorry, I don't understand what you mean by that. Do you think > the credit is undeserved? *shrug* ... i dont see other patches with things like: The patch was generated with git. The patch was generated with eclipse. The patch was generated with emacs. etc... we dont generally list all of the tools in the log message that was used in *creating* a patch since it doesnt really add any value when looking back historically at changes. -mike