mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Bryan Wu" <cooloney@kernel.org>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
	"Graf Yang" <graf.yang@analog.com>
Subject: Re: [PATCH 2/2] Blackfin Serial Driver: Add a debug function to serial driver.
Date: Fri, 15 Aug 2008 08:47:09 -0400	[thread overview]
Message-ID: <8bd0f97a0808150547x3abb3f47ha1438e8e7af1bfe5@mail.gmail.com> (raw)
In-Reply-To: <1218788617-8302-3-git-send-email-cooloney@kernel.org>

On Fri, Aug 15, 2008 at 4:23 AM, Bryan Wu wrote:
> +#ifdef CONFIG_DEBUG_KERNEL
> + ...
> +#else
> +void bfin_serial_debug(const char *fmt, ...)
> +{
> +       return;
> +}
> +EXPORT_SYMBOL(bfin_serial_debug);
> +#endif

it doesnt really make sense to export the symbol or make it available
when debugging is not enabled.
-mike

  reply	other threads:[~2008-08-15 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15  8:23 [PATCH 0/2] Blackfin Serial Drivers bug fixing (v2) Bryan Wu
2008-08-15  8:23 ` [PATCH 1/2] Blackfin Serial Driver: fix bug - Avoid null point exception in kgdb over UART Bryan Wu
2008-08-15  8:23 ` [PATCH 2/2] Blackfin Serial Driver: Add a debug function to serial driver Bryan Wu
2008-08-15 12:47   ` Mike Frysinger [this message]
2008-08-15  9:03 ` [PATCH 0/2] Blackfin Serial Drivers bug fixing (v2) Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0808150547x3abb3f47ha1438e8e7af1bfe5@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cooloney@kernel.org \
    --cc=graf.yang@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®