From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Bryan Wu" <bryan.wu@analog.com>
Cc: "Jesper Nilsson" <jesper.nilsson@axis.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
LKML <linux-kernel@vger.kernel.org>,
"Mikael Starvik" <mikael.starvik@axis.com>
Subject: Re: [RFC] CRIS: Move header files from include to arch/cris
Date: Tue, 21 Oct 2008 23:11:33 -0400 [thread overview]
Message-ID: <8bd0f97a0810212011o2dfc2290ra6b227fec3d89a57@mail.gmail.com> (raw)
In-Reply-To: <48FE91AE.4010009@analog.com>
On Tue, Oct 21, 2008 at 22:36, Bryan Wu wrote:
> Mike Frysinger wrote:
>> On Tue, Oct 21, 2008 at 12:42, Jesper Nilsson wrote:
>>> That means that the machine dependent header files are moved to
>>> arch/cris/mach-{fs,a3}/include, while the common and architecture
>>> dependent files are moved to arch/cris/include.
>>>
>>> It is mainly this I'd like some input on, since most other ports
>>> that have moved their header files have put all headers in
>>> arch/*/include.
>>
>> that seems like a fairly obvious good idea to me ... i'm thinking we
>> should do it for Blackfin as well ...
>
> For moving machine header files to arch/blackfin/include/asm/mach-bf{527,
> 533, 537, 538, 548, 561}, we need to set a link such as
> arch/blackfin/include/asm/mach -> arch/blackfin/include/asm/mach-bf527,
> because tons of drivers use the header file <asm/mach/xxxx.h>.
i dont think a ton of drivers use asm/mach/xxx.h considering how few
files we have in there. a transition would be pretty trivial.
> But we don't like to setup a link that is the one reason we move our header
> file from include/asm-blackfin to our arch/blackfin/include/asm.
$arch/include/asm/ and $arch/asm/ would work the same. just tweak the
actual -I path.
-mike
next prev parent reply other threads:[~2008-10-22 3:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 16:42 Jesper Nilsson
2008-10-21 17:46 ` Mike Frysinger
2008-10-21 19:17 ` Jesper Nilsson
2008-10-21 19:23 ` Mike Frysinger
2008-10-22 2:38 ` Bryan Wu
2008-10-22 2:36 ` Bryan Wu
2008-10-22 3:11 ` Mike Frysinger [this message]
2008-10-29 17:34 ` [PATCH] [CRIS] Move header files from include to arch/cris/include Jesper Nilsson
2008-10-29 18:53 ` Sam Ravnborg
2008-10-30 12:12 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0810212011o2dfc2290ra6b227fec3d89a57@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=bryan.wu@analog.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®