From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Greg KH" <gregkh@suse.de>
Cc: "Hans J. Koch" <hjk@linutronix.de>,
"Mike Frysinger" <vapier@gentoo.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UIO: only call pgprot_noncached if defined
Date: Wed, 5 Nov 2008 12:55:49 -0500 [thread overview]
Message-ID: <8bd0f97a0811050955k5fa31ccanc738b66348b83250@mail.gmail.com> (raw)
In-Reply-To: <20081105174234.GA10223@suse.de>
On Wed, Nov 5, 2008 at 12:42, Greg KH wrote:
> On Wed, Nov 05, 2008 at 12:33:37PM -0500, Mike Frysinger wrote:
>> On Wed, Nov 5, 2008 at 11:33, Greg KH wrote:
>> > On Wed, Nov 05, 2008 at 12:36:11PM +0100, Hans J. Koch wrote:
>> >> There seem to be archs that cannot easily implement a sensible
>> >> pgprot_noncached() function, so we should merge this patch. UIO doesn't
>> >> compile on these archs right now.
>> >
>> > No, we should fix those arches to have that function at least NULLed
>> > out. Isn't there only one, Blackfin? Putting #ifdefs in .c files is
>> > not something we really want to do if at all possible.
>>
>> that was my question. this function isnt documented. if the hardware
>> doesnt support it, is the right thing really for the arch to lie to
>> drivers and not actually give back cached settings even though it
>> asked for non-cached ?
>
> Probably not, it sounds like the arch needs to be fixed :)
i'd agree, but we're dealing with reality here: we're talking no-mmu
and we can not do caching on a per-page basis while maintaining
anything resembling usable performance.
-mike
next prev parent reply other threads:[~2008-11-05 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 17:26 Mike Frysinger
2008-10-29 20:53 ` Hans J. Koch
2008-11-05 0:06 ` Mike Frysinger
2008-11-05 11:36 ` Hans J. Koch
2008-11-05 16:33 ` Greg KH
2008-11-05 17:08 ` Hans J. Koch
2008-11-05 17:43 ` Mike Frysinger
2008-11-05 17:33 ` Mike Frysinger
2008-11-05 17:42 ` Greg KH
2008-11-05 17:55 ` Mike Frysinger [this message]
2008-11-05 18:27 ` Hans J. Koch
2008-11-05 18:36 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0811050955k5fa31ccanc738b66348b83250@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®