From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754518AbYKFLdH (ORCPT ); Thu, 6 Nov 2008 06:33:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753543AbYKFLcw (ORCPT ); Thu, 6 Nov 2008 06:32:52 -0500 Received: from rv-out-0506.google.com ([209.85.198.228]:41267 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753523AbYKFLcv (ORCPT ); Thu, 6 Nov 2008 06:32:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=pd3hv5MjVBydbi0Gu3jJIlrij49FHQ2xsa26JRqyEkWZ0xVbfNC9YxkKF6RRYnaBPG z1qYyDo9CDJByRUCIo4ORDTRT3kI5ss1SwS1L2K9FsM9x2RJSDj67btuGQMsC8yglzPq c6xy1gKhJ7PUdXIDxx8i7rFRMsd3FMbO9hu50= Message-ID: <8bd0f97a0811060332k281ae4d1m1fee62b27d811037@mail.gmail.com> Date: Thu, 6 Nov 2008 06:32:50 -0500 From: "Mike Frysinger" To: "Johannes Berg" Subject: Re: [PATCH] SSB: make it depend on PCI Cc: "Mike Frysinger" , "Michael Buesch" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <1225970982.3619.211.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1225965082-31462-1-git-send-email-vapier@gentoo.org> <1225969620.3619.204.camel@johannes.berg> <8bd0f97a0811060315j7d11e1a7p257a4a1bea640f7b@mail.gmail.com> <1225970573.3619.208.camel@johannes.berg> <8bd0f97a0811060326n5bcfc17fm5b5a65b12e71ea61@mail.gmail.com> <1225970982.3619.211.camel@johannes.berg> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 6, 2008 at 06:29, Johannes Berg wrote: > On Thu, 2008-11-06 at 06:26 -0500, Mike Frysinger wrote: >> On Thu, Nov 6, 2008 at 06:22, Johannes Berg wrote: >> > On Thu, 2008-11-06 at 06:15 -0500, Mike Frysinger wrote: >> >> while that may be the intent, it doesnt work today. >> >> >> >> drivers/ssb/main.c always includes linux/ssb/ssb.h >> >> >> >> linux/ssb/ssb.h always calls pci_dma_* functions >> >> >> >> arches that do not support PCI fail to build: >> >> CC drivers/ssb/main.o >> >> In file included from drivers/ssb/ssb_private.h:5, >> >> from drivers/ssb/main.c:12: >> >> include/linux/ssb/ssb.h: In function 'ssb_dma_mapping_error': >> >> include/linux/ssb/ssb.h:430: error: implicit declaration of function 'pci_dma_mapping_error' >> >> include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_for_cpu': >> >> include/linux/ssb/ssb.h:475: error: implicit declaration of function 'pci_dma_sync_single_for_cpu' >> >> include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_for_device': >> >> include/linux/ssb/ssb.h:493: error: implicit declaration of function 'pci_dma_sync_single_for_device' >> >> include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_range_for_cpu': >> >> include/linux/ssb/ssb.h:517: error: implicit declaration of function 'dma_sync_single_range_for_cpu' >> >> include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_range_for_device': >> >> include/linux/ssb/ssb.h:538: error: implicit declaration of function 'dma_sync_single_range_for_device' >> >> drivers/ssb/main.c: In function 'ssb_dma_set_mask': >> >> drivers/ssb/main.c:1183: error: implicit declaration of function 'dma_set_mask' >> > >> > >> > That seems odd, shouldn't at least the dma_sync_* functions and >> > dma_set_mask be supported? >> >> i'm highlighting the pci-specific functions. the common dma functions >> missing are not a ssb problem, so ignore those ;). > > Alright, but even then you'll fail build if you enable SSB ;) right ... but they're certainly nothing for you to worry about > I guess we > need ifdefs or mandate that non-PCI architectures have dummy stubs (like > other architectures have in the !CONFIG_PCI case), but Michael's the SSB > expert. OK. regarding the patch, if we drop the "&& PCI" part, i think the rest should get merged ... having empty menus in kconfig is annoying. agreed ? i can send out another one ... -mike