mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Julia Lawall" <julia@diku.dk>
Cc: dmitri.vorobiev@movial.fi, gregkh@suse.de,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions
Date: Wed, 10 Dec 2008 12:28:33 -0500	[thread overview]
Message-ID: <8bd0f97a0812100928l2c75d373n7eba5aa0cc3882fd@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812101725540.21998@ask.diku.dk>

On Wed, Dec 10, 2008 at 11:26, Julia Lawall wrote:
> The return value of the remove function of a driver structure, and thus of
> a platform_driver structure, is ultimately ignored, and is thus
> unnecessary.  The goal of this patch is to make it possible to convert the
> platform_driver functions stored in the remove field such that they return
> void.  This patch introduces a temporary field remove_new with return type
> void into the platform_driver structure, and updates the only place that
> the remove function is called to call the function in the remove_new field,
> if one is available.  The subsequent patches update some drivers to use the
> remove_new field.

why bother with remove -> remove_new convention ?  you'll get a
warning in C about the assignment, but you wont get a build failure,
nor should you get a runtime failure ... and if your ultimate goal is
to drop the return value, then this would be better as you'd get
warnings for everything that needs converting.  plus, once .remove is
gone, you're going to have to post another series of patches to
convert .remove_new back to .remove ...
-mike

  parent reply	other threads:[~2008-12-10 17:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-10 16:26 Julia Lawall
2008-12-10 16:38 ` Alan Cox
2008-12-10 18:03   ` Vorobiev Dmitri
2008-12-10 21:26     ` Anton Vorontsov
2008-12-10 22:06       ` Vorobiev Dmitri
2008-12-10 22:48         ` Anton Vorontsov
2008-12-10 17:28 ` Mike Frysinger [this message]
2008-12-10 22:18   ` Vorobiev Dmitri
2008-12-10 22:37     ` Mike Frysinger
2008-12-12  5:17       ` Greg KH
2008-12-12 11:00         ` Dmitri Vorobiev
2008-12-17 21:38           ` Greg KH
2008-12-12 21:00         ` Mike Frysinger
2008-12-17 21:37           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0812100928l2c75d373n7eba5aa0cc3882fd@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=dmitri.vorobiev@movial.fi \
    --cc=gregkh@suse.de \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®