From: Mike Frysinger <vapier.adi@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Bryan Wu <cooloney@kernel.org>,
felipe.balbi@nokia.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings
Date: Fri, 6 Feb 2009 23:29:54 -0500 [thread overview]
Message-ID: <8bd0f97a0902062029l7cfd58d2ga0c12f2c33cc9d93@mail.gmail.com> (raw)
In-Reply-To: <20090207000148.GF31059@kroah.com>
On Fri, Feb 6, 2009 at 19:01, Greg KH wrote:
> On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
>> From: Mike Frysinger <vapier.adi@gmail.com>
>>
>> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>> ---
>> drivers/usb/musb/blackfin.c | 9 +++++----
>> 1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
>> index 7861348..0ebb19d 100644
>> --- a/drivers/usb/musb/blackfin.c
>> +++ b/drivers/usb/musb/blackfin.c
>> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
>> void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
>> {
>> void __iomem *fifo = hw_ep->fifo;
>> +
>> +#ifdef CONFIG_BF52x
>
> Any way we can just not have ifdefs in .c files alltogether?
the sub arch.c files for musb are pretty much header files. the
alternative (splitting up the funcs into their own header files) would
be much more bothersome for us to maintain atm i think since there's
so very little different.
-mike
next prev parent reply other threads:[~2009-02-07 4:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 10:22 Bryan Wu
2009-02-06 19:15 ` Felipe Balbi
2009-02-06 19:24 ` Mike Frysinger
2009-02-06 19:26 ` Felipe Balbi
2009-02-06 19:28 ` Mike Frysinger
2009-02-06 19:30 ` Felipe Balbi
2009-02-12 6:01 ` David Brownell
2009-02-07 0:01 ` Greg KH
2009-02-07 4:29 ` Mike Frysinger [this message]
2009-02-07 5:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0902062029l7cfd58d2ga0c12f2c33cc9d93@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cooloney@kernel.org \
--cc=felipe.balbi@nokia.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®