From: Mike Frysinger <vapier.adi@gmail.com>
To: Tim Abbott <tabbott@mit.edu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
linux arch <linux-arch@vger.kernel.org>,
Anders Kaseorg <andersk@mit.edu>
Subject: Re: [PATCH v2 0/6] macros for section name cleanup
Date: Mon, 4 May 2009 13:42:08 -0400 [thread overview]
Message-ID: <8bd0f97a0905041042g71af324eo1d38e35799836c86@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0905041209570.10610@vinegar-pot.mit.edu>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1838 bytes --]
On Mon, May 4, 2009 at 12:32, Tim Abbott wrote:> On Mon, 4 May 2009, Sam Ravnborg wrote:>> +#define RW_DATA_SECTION(page_align, readmostly_align, cache_align,>> inittask_align) \>> + Â Â . = ALIGN(PAGE_SIZE); Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \>> + Â Â .data : AT(ADDR(.data) - LOAD_OFFSET) { Â Â Â Â Â Â Â Â Â Â Â Â \>> + Â Â Â Â Â Â DATA_DATA Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \>> + Â Â Â Â Â Â CONSTRUCTORS Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \>> + Â Â Â Â Â Â NOSAVE_DATA Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \>> + Â Â Â Â Â Â PAGE_ALIGNED_DATA(page_align) Â Â Â Â Â Â Â Â Â Â Â Â Â \>> + Â Â Â Â Â Â READMOSTLY_DATA(readmostly_align) Â Â Â Â Â Â Â Â Â Â Â \>> + Â Â Â Â Â Â CACHELINE_ALIGNED_DATA(cache_align) Â Â Â Â Â Â Â Â Â Â \>> + Â Â Â Â Â Â INIT_TASK(inittask_align) Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \>> + Â Â }>> How did you pick the order of the sections here? Â I would think that to> pack the .data section efficiently, you'd want to sort by alignment> requirements so that e.g. all the at-least-page aligned sections are> adjacent (INIT_TASK and the page-aligned sections are separated by some> much smaller aligments here).
if this were actually the case, there should of course be some /*comments */ above the define explaining that the order wasntarbitrarily pulled like a rabbit from an orifice. if you'rescratching your head, then there's going to be plenty more people whonever ask but treat it like untouchable voodoo.-mikeÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2009-05-04 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1241121253-32341-1-git-send-email-tabbott@mit.edu>
2009-05-01 21:31 ` Sam Ravnborg
2009-05-02 0:48 ` Tim Abbott
2009-05-02 22:01 ` Sam Ravnborg
2009-05-04 14:27 ` Sam Ravnborg
2009-05-04 14:30 ` [PATCH/RFC] Sample conversion of powerpc Sam Ravnborg
2009-05-04 16:32 ` [PATCH v2 0/6] macros for section name cleanup Tim Abbott
2009-05-04 17:42 ` Mike Frysinger [this message]
2009-05-04 17:54 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0905041042g71af324eo1d38e35799836c86@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=andersk@mit.edu \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tabbott@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®