From: Mike Frysinger <vapier.adi@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Mike Frysinger <vapier@gentoo.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Cliff Cai <cliff.cai@analog.com>, Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH 04/11] Blackfin SPORT UART: fix overrun errors
Date: Wed, 3 Jun 2009 04:03:46 -0400 [thread overview]
Message-ID: <8bd0f97a0906030103i64bc1a9duc5aeaea7bd3f8365@mail.gmail.com> (raw)
In-Reply-To: <20090602100018.415b1dfc@lxorguk.ukuu.org.uk>
On Tue, Jun 2, 2009 at 05:00, Alan Cox wrote:
> On Tue, 2 Jun 2009 03:11:33 -0400 Mike Frysinger wrote:
>> From: Cliff Cai <cliff.cai@analog.com>
>>
>> Push the ty_flip_buffer_push() call from the IRQ handler to a timer so as
>> to improve performance and decrease likelihood of overruns.
>
> This should have no effect on a modern kernel.
well, we wouldnt be making changes if we werent seeing data overruns today
> There is 64K of queueing between you and the ldisc nowdays.
i dont think that really matters ... we do too much work in the
interrupt and so we miss new data
> Furthermore unless you set tty->low_latency the kernel already basically
> does this aggregation for you as the buffer push queues stuff for the ldisc
> to wake up and process.
i guess we could try setting the low_latency bool instead and see if
that fixes things
-mike
next prev parent reply other threads:[~2009-06-03 8:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 7:11 [PATCH 01/11] Blackfin SPORT UART: fix typo in sport_set_termios prototype Mike Frysinger
2009-06-02 7:11 ` [PATCH 02/11] Blackfin SPORT UART: fix data misses while using transmit frame sync Mike Frysinger
2009-06-02 7:11 ` [PATCH 03/11] Blackfin SPORT UART: rewrite inline assembly Mike Frysinger
2009-06-02 7:11 ` [PATCH 04/11] Blackfin SPORT UART: fix overrun errors Mike Frysinger
2009-06-02 9:00 ` Alan Cox
2009-06-03 8:03 ` Mike Frysinger [this message]
2009-06-03 8:49 ` Cai, Cliff
2009-06-03 8:53 ` Alan Cox
2009-06-03 9:47 ` Mike Frysinger
2009-06-03 9:57 ` Alan Cox
2009-06-03 10:15 ` Mike Frysinger
2009-06-02 7:11 ` [PATCH 05/11] Blackfin Serial Driver: fix error while transferring large files Mike Frysinger
2009-06-02 7:11 ` [PATCH 06/11] Blackfin Serial Driver: fix baudrate for early_printk Mike Frysinger
2009-06-02 7:11 ` [PATCH 07/11] Blackfin Serial Driver: fix missing new lines when under load Mike Frysinger
2009-06-02 7:11 ` [PATCH 08/11] Blackfin Serial Driver: handle irregular DMA register status in auto start mode Mike Frysinger
2009-06-02 7:11 ` [PATCH 09/11] Blackfin Serial Driver: annotate anomalies 05000215 and 05000099 Mike Frysinger
2009-06-02 7:11 ` [PATCH 10/11] Blackfin Serial Driver: handle anomaly 05000231 Mike Frysinger
2009-06-02 7:11 ` [PATCH 11/11] Blackfin Serial Driver: disable dma rx interrupt only rather than all irqs Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0906030103i64bc1a9duc5aeaea7bd3f8365@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®