From: Mike Frysinger <vapier.adi@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf_counters: start documenting HAVE_PERF_COUNTERS requirements
Date: Fri, 12 Jun 2009 13:40:52 -0400 [thread overview]
Message-ID: <8bd0f97a0906121040m5222cd5et77ecc1bd5edb6b89@mail.gmail.com> (raw)
In-Reply-To: <20090612173647.GC22015@elte.hu>
On Fri, Jun 12, 2009 at 13:36, Ingo Molnar wrote:
> * Mike Frysinger <vapier.adi@gmail.com> wrote:
>> On Fri, Jun 12, 2009 at 13:30, Ingo Molnar wrote:
>> > * Mike Frysinger <vapier@gentoo.org> wrote:
>> >> Help out arch porters who want to support perf counters by listing some
>> >> basic requirements.
>> >>
>> >> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> >> ---
>> >> i imagine more details would be good, but this is a starting point and
>> >> better than nothing
>> >>
>> >> init/Kconfig | 2 ++
>> >> tools/perf/design.txt | 15 +++++++++++++++
>> >> 2 files changed, 17 insertions(+), 0 deletions(-)
>> >>
>> >> diff --git a/init/Kconfig b/init/Kconfig
>> >> index c649657..20f85b1 100644
>> >> --- a/init/Kconfig
>> >> +++ b/init/Kconfig
>> >> @@ -936,6 +936,8 @@ config AIO
>> >>
>> >> config HAVE_PERF_COUNTERS
>> >> bool
>> >> + help
>> >> + See end of tools/perf/design.txt
>> >>
>> >> menu "Performance Counters"
>> >
>> > Applied, thanks Mike! I have made a small change: i changed it from
>> > help text into a regular comment. We usually use help texts for
>> > interactive Kconfig options - but this is not one.
>>
>> yes, but i like the help text because when i use the kconfig
>> search option, it shows up. otherwise doing a search for
>> HAVE_PERF_COUNTERS shows nothing useful.
>
> When i did this modification i tried that in 'make menuconfig' and
> the help didnt show up. Is it only available in certain kconfig
> methods?
hrm, you're right. not sure what i was thinking of. sounds like an
enhancement request though for kconfig.
-mike
next prev parent reply other threads:[~2009-06-12 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 17:17 Mike Frysinger
2009-06-12 17:17 ` Randy Dunlap
2009-06-12 17:27 ` Mike Frysinger
2009-06-14 9:41 ` Paul Mundt
2009-06-14 9:51 ` Mike Frysinger
2009-06-12 17:30 ` Ingo Molnar
2009-06-12 17:32 ` Mike Frysinger
2009-06-12 17:36 ` Ingo Molnar
2009-06-12 17:40 ` Mike Frysinger [this message]
2009-06-12 17:40 ` Randy Dunlap
2009-06-12 17:56 ` Sam Ravnborg
2009-06-12 17:53 ` Randy Dunlap
2009-06-12 17:33 ` [tip:perfcounters/core] perf_counter: Start " tip-bot for Mike Frysinger
2009-06-12 17:39 ` tip-bot for Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0906121040m5222cd5et77ecc1bd5edb6b89@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®