From: Mike Frysinger <vapier.adi@gmail.com>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: module version magic and arches with symbol prefixes
Date: Fri, 19 Jun 2009 14:32:15 -0400 [thread overview]
Message-ID: <8bd0f97a0906191132n42eda4e3n680503c56f22640a@mail.gmail.com> (raw)
In-Reply-To: <200906191307.45135.rgetz@blackfin.uclinux.org>
On Fri, Jun 19, 2009 at 13:07, Robin Getz wrote:
> On Fri 19 Jun 2009 09:14, Mike Frysinger pondered:
>> On Fri, Jun 19, 2009 at 08:54, Robin Getz wrote:
>> > On Fri 19 Jun 2009 01:38, Rusty Russell pondered:
>> >> No, it means the kernel didn't build properly.
>> >
>> > Or a module didn't build properly.
>>
>> nah, when i talked to you earlier i was wrong -- this find_symbol() is
>> looking up the symbol in the kernel, not in the module. the lookup of
>> the symbol in the requested module actually works.
>
> Wouldn't it make sense to move this somewhere else then? and add a
> __initcall() for it? We should only need to check for it once - it would make
> things insignificantly faster, and smaller :)
it would also have the advantage of the BUG() being noticed sooner ...
but up to Rusty i guess.
-mike
next prev parent reply other threads:[~2009-06-19 18:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 15:24 Mike Frysinger
2009-06-19 5:38 ` Rusty Russell
2009-06-19 7:49 ` [PATCH] module: use MODULE_SYMBOL_PREFIX with module_layout Mike Frysinger
2009-06-19 14:02 ` Rusty Russell
2009-06-19 18:29 ` Mike Frysinger
2009-06-19 12:54 ` module version magic and arches with symbol prefixes Robin Getz
2009-06-19 13:14 ` Mike Frysinger
2009-06-19 17:07 ` Robin Getz
2009-06-19 18:32 ` Mike Frysinger [this message]
2009-06-23 7:07 ` Rusty Russell
2009-06-29 12:07 ` Robin Getz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0906191132n42eda4e3n680503c56f22640a@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgetz@blackfin.uclinux.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®