From: Mike Frysinger <vapier.adi@gmail.com>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: Jonathan Cameron <Jonathan.Cameron@gmail.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
Chris Verges <chrisv@cyberswitching.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
Robin Getz <rgetz@blackfin.uclinux.org>
Subject: Re: [lm-sensors] [PATCH] adxl345 accelerometer hwmon driver
Date: Thu, 2 Jul 2009 14:15:02 -0400 [thread overview]
Message-ID: <8bd0f97a0907021115r761d7906w818acefc6c03efa4@mail.gmail.com> (raw)
In-Reply-To: <8A42379416420646B9BFAC9682273B6D0C2497DC@limkexm3.ad.analog.com>
On Thu, Jul 2, 2009 at 14:12, Hennerich, Michael wrote:
>From: J.I. Cameron [mailto:jic23@hermes.cam.ac.uk] On Behalf Of
>> Looks like a nice driver, see what you mean about the i2c fun and games
>> you are having though.
>> I'm particularly interested in your use of the fifo:
>>
>>I've only had a quick look, but assuming I read it right, you are using
>>the fifo
>>with a watermark of 0 then spitting out 3 separate events for every
>>element in it.
>>Basically a data ready response unless you fail to read in time. Seems
>>like a sensible
>>approach with this particular chip in input type applications.
>
> We fully use the FIFO - the link Mike sent around was the initial
> checkin.
> After that I fixes some bugs and added functionality.
> BTW I also implemented the Watermark feature.
nah, that link i posted is everything. the kernel.org repo has
cleaned up / squashed changes. so all the little pieces in our
personal repo have been put together to form the one changeset on
kernel.org.
ive been emptying my other subsystem queues and havent gotten around
to input/hwmon/fb yet. i'll start up a thread on our list to see what
people are happy with submitting.
-mike
next prev parent reply other threads:[~2009-07-02 18:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Acn6eDhBoTUmzVqOSVGG9a2LiwqVrA==>
2009-07-01 18:17 ` Chris Verges
2009-07-01 19:10 ` [lm-sensors] " Jonathan Cameron
2009-07-01 19:19 ` Chris Verges
2009-07-01 20:13 ` Jean Delvare
2009-07-01 20:52 ` Chris Verges
2009-07-02 11:25 ` Jean Delvare
2009-07-02 13:55 ` Jonathan Cameron
2009-07-02 8:04 ` Éric Piel
2009-07-01 19:33 ` [lm-sensors] " Jean Delvare
2009-07-02 17:38 ` Jonathan Cameron
2009-07-02 17:43 ` Mike Frysinger
2009-07-02 17:59 ` Jonathan Cameron
2009-07-02 18:12 ` Hennerich, Michael
2009-07-02 18:15 ` Mike Frysinger [this message]
2009-07-02 17:59 ` Hennerich, Michael
2009-08-14 11:05 ` XingChao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0907021115r761d7906w818acefc6c03efa4@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=Jonathan.Cameron@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=chrisv@cyberswitching.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rgetz@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®