Re: [RFC PATCH] linker script: unify usage of discard definition

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: Mike Frysinger <vapier.adi@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Michal Simek <monstr@monstr.eu>,
	microblaze-uclinux@itee.uq.edu.au,
	Sam Ravnborg <sam@ravnborg.org>, Paul Mundt <lethal@linux-sh.org>,
	Tony Luck <tony.luck@intel.com>
Subject: Re: [RFC PATCH] linker script: unify usage of discard definition
Date: Sat, 4 Jul 2009 01:51:04 -0400	[thread overview]
Message-ID: <8bd0f97a0907032251p753527e1oac25ea1740a1bfdb@mail.gmail.com> (raw)
In-Reply-To: <4A4E9638.20304@kernel.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1416 bytes --]

On Fri, Jul 3, 2009 at 19:37, Tejun Heo wrote:> +/*> + * DISCARDS must be the last and archs which want some of the default> + * discarded sections in the kernel image can do so by putting them in> + * earlier section definition.> + */> Â #define DISCARDS Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  \> Â  Â  Â  Â /DISCARD/ : { Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  \> Â  Â  Â  Â EXIT_TEXT Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  \> Â  Â  Â  Â EXIT_DATA Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  \> - Â  Â  Â  *(.exitcall.exit) Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  \> + Â  Â  Â  EXIT_CALL Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  \> Â  Â  Â  Â *(.discard) Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  \> Â  Â  Â  Â }
i would add to the comment that some people want to discard exittext/data at runtime rather than link time due to cross-sectionreferences such as alt instructions, bug table, eh_frame, etc...
otherwise, looks good to me.  thanks !
Acked-by: Mike Frysinger <vapier@gentoo.org>-mikeÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

next prev parent reply	other threads:[~2009-07-04  5:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-03 23:37 Tejun Heo
2009-07-04  1:34 ` linux-next submission requirements (Was: [RFC PATCH] linker script: unify usage of discard definition) Stephen Rothwell
2009-07-04  3:18   ` Tejun Heo
2009-07-04  4:03     ` Stephen Rothwell
2009-07-04  4:07       ` Tejun Heo
2009-07-04  5:51 ` Mike Frysinger [this message]
2009-07-04 15:37   ` [RFC PATCH] linker script: unify usage of discard definition Paul Mundt
2009-07-04 18:40 ` [microblaze-uclinux] " Michal Simek
2009-07-06  6:17 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0907032251p753527e1oac25ea1740a1bfdb@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=monstr@monstr.eu \
    --cc=sam@ravnborg.org \
    --cc=tj@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®