From: Mike Frysinger <vapier.adi@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Robin Getz <rgetz@blackfin.uclinux.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] kernel.printk.c - ensure that "console enabled"messages are printed on the console
Date: Fri, 10 Jul 2009 10:26:01 -0400 [thread overview]
Message-ID: <8bd0f97a0907100726i6d00c75q1189080dea711831@mail.gmail.com> (raw)
In-Reply-To: <20090710141618.GF26264@elte.hu>
On Fri, Jul 10, 2009 at 10:16, Ingo Molnar wrote:
> * Robin Getz wrote:
>> On Fri 10 Jul 2009 06:25, Ingo Molnar pondered:
>> > - re-broke the commit log as it was too wide for nice git log
>> > output
>>
>> Hmm - I didn't know there was a restriction on this - what is the number?
>
> 'git log' adds 4 leading spaces to commit messages and then if you
> look at it via a small terminal it can quickly wrap at the end,
> making the commit log harder to read.
>
> Also, commit logs get quoted in emails and if we reply to that in up
> to a depth of 4, the colums do get eaten up quickly.
>
> 60 cols sounds like a reasonable compromise. There's no 'written'
> rule for this AFAIK, i just do it for all changes i commit, to
> increase commit quality.
the upper rule based on what you point out:
- git-log adds 4 and 80 cols is the min directly supported
- logs go through e-mail which wraps at 78
leaves us with user-typed paragraphs at 76
for copy & pasted output (i.e. gcc output and kernel crash logs), i
welsh on that a bit as it leaves it up to the viewer to wrap like
normal.
-mike
next prev parent reply other threads:[~2009-07-10 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-04 4:17 Boot Consoles question Robin Getz
2009-07-04 10:29 ` Ingo Molnar
2009-07-04 16:07 ` Robin Getz
2009-07-07 23:49 ` Robin Getz
2009-07-10 10:28 ` Ingo Molnar
2009-07-10 14:28 ` Robin Getz
2009-07-10 16:08 ` Ingo Molnar
2009-07-09 17:08 ` [PATCH] kernel.printk.c - ensure that "console enabled" messages are printed on the console Robin Getz
2009-07-10 10:25 ` Ingo Molnar
2009-07-10 14:13 ` [PATCH] kernel.printk.c - ensure that "console enabled"messages " Robin Getz
2009-07-10 14:16 ` Ingo Molnar
2009-07-10 14:26 ` Mike Frysinger [this message]
2009-07-18 0:48 ` [PATCH] kernel.printk.c - ensure that "console enabled" messages " Andrew Morton
2009-07-20 5:29 ` Stephen Rothwell
2009-07-10 10:43 ` [tip:core/printk] printk: Ensure " tip-bot for Robin Getz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0907100726i6d00c75q1189080dea711831@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rgetz@blackfin.uclinux.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®