mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier.adi@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: Bernd Schmidt <bernds_cb1@t-online.de>,
	uclinux-dist-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Uclinux-dist-devel] [PATCH v2] NOMMU: add support for Memory  Protection Units (MPU)
Date: Wed, 15 Jul 2009 08:52:23 -0400	[thread overview]
Message-ID: <8bd0f97a0907150552rb69b953t85e73d14a995efb3@mail.gmail.com> (raw)
In-Reply-To: <3751.1247660742@redhat.com>

On Wed, Jul 15, 2009 at 08:25, David Howells wrote:
> Mike Frysinger wrote:
>> yes, you can see page_rwx_mask in our mmu.h's mm_context_t.  this is
>> what the protect_page/update_protections operate on.  we have a global
>> current_rwx_mask that gets updated during context changes and the CPLB
>> miss handler uses that to keep things simple.
>
> Interesting.
>
> Since FRV does not really allow separate execute permissions (it has a very
> few separate static I and D protection/mapping registers and a shared TLB), I
> could do it with just pairs of bits.
>
> Also, how do you deal with mappable devices that lie outside of RAM?  I'm
> guessing from the code that you don't cover those with the bitmap, but rather
> just grant userspace RW access.

yes, there are really only three such regions on Blackfin systems:
 - on-chip rom
 - async memory banks
 - on-chip sram

since the first is read-only, letting random things execute/read there
isnt going to cause a problem.  any supervisor-only
accesses/instructions would be caught anyways if userspace attempted
it.

the second could (should?) be restricted like normal (granting access
via ioremap/mmap), but right now we just grant full access to
everyone.  the banks are largely used for drivers only
(usb/eth/flash/fpga/etc...), so having protection for that region
doesnt gain us too much.  perhaps down the line we'll look into it.

the on-chip srams are so small that 4k (or even 1k -- the smallest
page we can handle) would waste most resources.  so we either lock a
CPLB entry for full access (L1), or always grant it (L2).  and again,
experience has shown that it is largely used by drivers only, so
protection here wouldnt gain much as there is so rarely bad behavior
going on.
-mike

  reply	other threads:[~2009-07-15 12:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14 14:22 [PATCH] " Mike Frysinger
2009-07-14 16:14 ` Johannes Weiner
2009-07-14 16:19   ` Mike Frysinger
2009-07-14 17:14   ` [PATCH v2] " Mike Frysinger
2009-09-14  3:52     ` Mike Frysinger
2009-09-16 10:09     ` David Howells
2009-07-14 17:22   ` David Howells
2009-07-14 21:59     ` Bernd Schmidt
2009-07-15  9:24     ` Paul Mundt
2009-07-15 10:31     ` David Howells
2009-07-15 11:18       ` [Uclinux-dist-devel] " Mike Frysinger
2009-07-15 10:37     ` David Howells
2009-07-15 11:12       ` [Uclinux-dist-devel] " Mike Frysinger
2009-07-15 11:45       ` David Howells
2009-07-15 11:55         ` Mike Frysinger
2009-07-15 12:25         ` David Howells
2009-07-15 12:52           ` Mike Frysinger [this message]
2009-09-16 13:57 ` [PATCH] " Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0907150552rb69b953t85e73d14a995efb3@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=bernds_cb1@t-online.de \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®