mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier.adi@gmail.com>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] Convert blackfin to use arch_gettimeoffset()
Date: Thu, 16 Jul 2009 22:26:04 -0400	[thread overview]
Message-ID: <8bd0f97a0907161926j258da72cg9dd1ca76ea8be2fb@mail.gmail.com> (raw)
In-Reply-To: <1247790356.7398.14.camel@localhost.localdomain>

On Thu, Jul 16, 2009 at 20:25, john stultz wrote:
> This patch converts blackfin to use GENERIC_TIME via the arch_getoffset()
> infrastructure, reducing the amount of arch specific code we need to
> maintain.
>
> This patch applies on top of Linus' current -git tree (2.6.31-rc3).
>
> I've taken my best swing at converting this, but I'm not 100% confident
> I got it right. My cross-compiler is now out of date (gcc4.2) so I
> wasn't able to  check if it compiled. Any assistance from arch
> maintainers or testers to get this merged would be great.

something seems to be off as the Blackfin defconfig now does:
  LD      .tmp_vmlinux1
kernel/built-in.o: In function `clocksource_forward_now':
kernel/time/timekeeping.c:82: undefined reference to `arch_gettimeoffset'
kernel/built-in.o: In function `getnstimeofday':
kernel/time/timekeeping.c:119: undefined reference to `arch_gettimeoffset'
make: *** [.tmp_vmlinux1] Error 1

most likely because the Blackfin time.c is the old stuff
(non-clocksource) while time-ts.c is the newer stuff (clocksource) and
this change only touches time.c
-mike

  reply	other threads:[~2009-07-17  2:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 22:10 [PATCH] Convert alpha " john stultz
2009-06-11 22:21 ` Dialup Jon Norstog
2009-06-11 22:52 ` [PATCH] Convert m32r " john stultz
2009-06-12  7:03 ` [PATCH] Convert alpha " Richard Henderson
2009-06-12 18:41   ` john stultz
2009-06-16 17:45     ` Richard Henderson
2009-06-17 15:29       ` Ivan Kokshaysky
2009-07-17  0:09 ` [RESEND][PATCH] Convert m32r " john stultz
2009-07-17  0:17 ` [PATCH] Convert cris " john stultz
2009-07-17  0:20 ` [PATCH] Convert m68k " john stultz
2009-07-17  0:25 ` [PATCH] Convert blackfin " john stultz
2009-07-17  2:26   ` Mike Frysinger [this message]
2009-07-17  5:17     ` john stultz
2009-07-17  5:33     ` john stultz
2009-07-20  8:24       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0907161926j258da72cg9dd1ca76ea8be2fb@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome