From: Mike Frysinger <vapier.adi@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Tim Abbott <tabbott@ksplice.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bryan Wu <cooloney@kernel.org>,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] blackfin: Cleanup linker script using new linker script macros.
Date: Wed, 16 Sep 2009 16:37:32 -0400 [thread overview]
Message-ID: <8bd0f97a0909161337v6edbe204wfd83b4c3118b3a27@mail.gmail.com> (raw)
In-Reply-To: <20090916202655.GA17153@merkur.ravnborg.org>
On Wed, Sep 16, 2009 at 16:26, Sam Ravnborg wrote:
> On Wed, Sep 16, 2009 at 11:58:01AM -0400, Tim Abbott wrote:
>> On Tue, 15 Sep 2009, Mike Frysinger wrote:
>> > the larger padding in the initramfs is kind of annoying as i cant see
>> > any need to pad it to PAGE_SIZE. since the initramfs is released with
>> > the rest of the init section, it doesnt need whole pages. a quick
>> > test shows that it does waste a few kb in reality. default build for
>> > BF533-STAMP for example shows 0x1000 difference.
>> >
>> > in terms of correctness, this change misses a reference to the now
>> > deleted .init.ramfs:
>> > - .init.ramfs :
>> > - {
>> > - .....
>> > - }
>> > -
>> > .text_l1 L1_CODE_START : AT(LOADADDR(.init.ramfs) + SIZEOF(.init.ramfs))
>> >
>> > so that .text_l1 needs to updated to refer to the new section before
>> > it (.exit.data in this case). once i make that change, the resulting
>> > link looks the same (minus the initramfs thing mentioned earlier), and
>> > it does boot.
>>
>> OK. I guess we should plan to modify the INIT_DATA_SECTION macro to add
>> another argument specifying an alignment level for .init.ramfs. It'd be
>> inconvenient to add that right now since there are a lot of patches in
>> linux-next or otherwise in flight that introduce uses of
>> INIT_DATA_SECTION, and those patches would all be broken by changing this
>> now. Once the dust settles on that for this release, I'll submit a patch
>> adding said argument to INIT_DATA_SECTION.
>
> But this is all discarded during runtime so the added alignment has no cost in the end - no?
once things are booted, there should be no difference. but
storage/boot costs increase (you have to store/extract/copy that extra
data). you know how miserly we embedded people like to be ;).
-mike
next prev parent reply other threads:[~2009-09-16 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-07 3:05 Tim Abbott
2009-09-16 3:13 ` Mike Frysinger
2009-09-16 15:58 ` Tim Abbott
2009-09-16 16:56 ` Mike Frysinger
2009-09-16 20:26 ` Sam Ravnborg
2009-09-16 20:37 ` Mike Frysinger [this message]
2009-09-22 15:29 ` Tim Abbott
2009-09-22 15:30 ` Mike Frysinger
2009-09-22 15:39 ` Tim Abbott
2009-09-22 15:46 ` Mike Frysinger
2009-09-22 15:51 ` Tim Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0909161337v6edbe204wfd83b4c3118b3a27@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®