From: Mike Frysinger <vapier.adi@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs
Date: Sun, 20 Sep 2009 18:40:41 -0400 [thread overview]
Message-ID: <8bd0f97a0909201540t25dd2337o15ebe63a2a9ca4ec@mail.gmail.com> (raw)
In-Reply-To: <20090919233044.8361a912.akpm@linux-foundation.org>
On Sun, Sep 20, 2009 at 02:30, Andrew Morton wrote:
> On Thu, 17 Sep 2009 14:24:10 -0400 Mike Frysinger wrote:
>> +struct adp5520_keys {
>> + struct input_dev *input;
>> + struct notifier_block notifier;
>> + struct device *master;
>> + unsigned short keycode[ADP5520_KEYMAPSIZE];
>
> Where is ADP5520_KEYMAPSIZE defined?
all these things are in the common mfd adp5520 patch. it introduces a
common adp5520 header.
>> + for (i = 0; i < ADP5520_MAXKEYS; i++)
>> + if (keymask & (1 << i))
>> + input_report_key(dev->input, dev->keycode[i], value);
>
> It seems odd that keycode is dimensioned with ADP5520_KEYMAPSIZE but
> here we iterate up to ADP5520_MAXKEYS.
ARRAY_SIZE() probably makes more sense
-mike
next prev parent reply other threads:[~2009-09-20 22:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 18:24 Mike Frysinger
2009-09-20 6:30 ` Andrew Morton
2009-09-20 22:40 ` Mike Frysinger [this message]
2009-09-21 4:04 ` [Uclinux-dist-devel] " Andrew Morton
2009-09-21 13:40 ` Mike Frysinger
2009-09-21 18:23 ` Andrew Morton
2009-09-22 5:59 ` Dmitry Torokhov
2009-09-22 7:33 ` Jiri Kosina
2009-09-22 7:53 ` Hennerich, Michael
2009-09-22 7:56 ` Jiri Kosina
2009-09-22 14:21 ` Mike Frysinger
2009-09-22 15:06 ` Dmitry Torokhov
2009-09-23 5:15 ` [PATCH v2] " Mike Frysinger
2009-09-23 6:28 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0909201540t25dd2337o15ebe63a2a9ca4ec@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome