From: Mike Frysinger <vapier.adi@gmail.com>
To: Matt Fleming <matt@console-pimps.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/checksum.c: Fix another endianess bug
Date: Mon, 28 Sep 2009 16:39:38 -0400 [thread overview]
Message-ID: <8bd0f97a0909281339p1abe6ff0h1ef4e05887a2413d@mail.gmail.com> (raw)
In-Reply-To: <20090928080729.GB6793@console-pimps.org>
On Mon, Sep 28, 2009 at 04:07, Matt Fleming wrote:
> On Fri, Sep 25, 2009 at 01:00:25PM -0400, Mike Frysinger wrote:
>> On Fri, Sep 25, 2009 at 10:20, Matt Fleming wrote:
>> > From: Matt Fleming <matthew.fleming@imgtec.com>
>> >
>> > This fix allows the generic checksum code to work on my little endian
>> > system. The previous fix was not enough, as "buff" is a big-endian
>> > value. Without this patch I see malformed TCP packets.
>>
>> can you try this one ?
>> http://lkml.org/lkml/2009/6/23/597
>
> Yep, that one works fine also. Thanks, Mike. Who's going to pick this
> up? I'm guessing this commit is also applicable for stable? Though, I
> don't know if there are any little-endian users of this code in stable.
i'm converting Blackfin to it now that the LE issues should be fixed,
but i'm going to hold off on pushing the change until it can be tested
as for picking up the fix, let's ask Andrew ...
-mike
next prev parent reply other threads:[~2009-09-28 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 14:20 Matt Fleming
2009-09-25 17:00 ` Mike Frysinger
2009-09-28 8:07 ` Matt Fleming
2009-09-28 20:39 ` Mike Frysinger [this message]
2009-10-24 11:59 ` Matt Fleming
2009-10-24 22:51 ` Mike Frysinger
2009-10-25 10:03 ` [PATCH] lib/checksum.c: lib/checksum: fix one more thinko Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0909281339p1abe6ff0h1ef4e05887a2413d@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®