From: Mike Frysinger <vapier.adi@gmail.com>
To: cliffcai.sh@gmail.com
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
cliff.cai@analog.com
Subject: Re: [PATCH][mmc/host]:Blackfin SD Host Controller Driver
Date: Tue, 24 Nov 2009 11:35:56 -0500 [thread overview]
Message-ID: <8bd0f97a0911240835j1d360b39tda688e551052c5c7@mail.gmail.com> (raw)
In-Reply-To: <1259077143-25864-1-git-send-email-cliffcai.sh@gmail.com>
On Tue, Nov 24, 2009 at 10:39, <cliffcai.sh@gmail.com> wrote:
> From: Cliff Cai <cliffcai.sh@gmail.com>
>
> Signed-off-by: Cliff Cai <cliffcai.sh@gmail.com>
you dropped some people's s-o-b tags
> +out4:
> + free_irq(host->irq, host);
you didnt address the feedback given last time here:
You need a mmc_remove_host() here.
-mike
next prev parent reply other threads:[~2009-11-24 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 15:39 cliffcai.sh
2009-11-24 16:35 ` Mike Frysinger [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-16 9:32 [PATCH] [mmc/host]:Blackfin " cliffcai.sh
2009-04-16 8:55 ` Jaswinder Singh Rajput
2009-04-16 9:10 ` Cai, Cliff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0911240835j1d360b39tda688e551052c5c7@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cliff.cai@analog.com \
--cc=cliffcai.sh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®