mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier.adi@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: Paul Mundt <lethal@linux-sh.org>,
	Bernd Schmidt <bernds_cb1@t-online.de>,
	Jie Zhang <jie.zhang@analog.com>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	uclinux-dist-devel <uclinux-dist-devel@blackfin.uclinux.org>
Subject: Re: avoiding duplicate icache flushing of shared maps on nommu
Date: Wed, 2 Dec 2009 17:41:31 -0500	[thread overview]
Message-ID: <8bd0f97a0912021441m5976be3dw29eef46ba4e76bf9@mail.gmail.com> (raw)
In-Reply-To: <15859.1259763330@redhat.com>

On Wed, Dec 2, 2009 at 09:15, David Howells wrote:
> Mike Frysinger wrote:
> +               flush_icache_range(region->vm_start,
> +                                  region->vm_end - region->vm_start);
> -               flush_icache_range(result, result + len);

actually, there's one typo here.  you want:
flush_icache_range(region->vm_start, region->vm_end);

it doesnt crash on blackfin systems as addresses not in icache get
nopped, but it was causing large delays on exec mappings.  i thought
this was due to the nic on the board i was using as it's hitting some
weird pauses by itself.
-mike

  parent reply	other threads:[~2009-12-02 22:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-28 15:40 Mike Frysinger
2009-11-28 18:53 ` Mike Frysinger
2009-11-30  3:18 ` Jie Zhang
2009-12-02 14:15 ` David Howells
2009-12-02 21:40   ` Mike Frysinger
2009-12-02 22:41   ` Mike Frysinger [this message]
2009-12-02 23:51   ` David Howells
2009-12-03 16:14   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0912021441m5976be3dw29eef46ba4e76bf9@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=bernds_cb1@t-online.de \
    --cc=dhowells@redhat.com \
    --cc=jie.zhang@analog.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome