From: Mike Frysinger <vapier.adi@gmail.com>
To: Li Yi <yi.li@analog.com>, Arnd Bergmann <arnd@arndb.de>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] Ftrace: irqsoff tracer may cause stack overflow
Date: Thu, 7 Jan 2010 23:54:18 -0500 [thread overview]
Message-ID: <8bd0f97a1001072054y798833dftdb1b2a744ad52969@mail.gmail.com> (raw)
In-Reply-To: <1262925925.27700.15.camel@adam-desktop>
On Thu, Jan 7, 2010 at 23:45, Li Yi wrote:
> "irqsoff" tracer may cause stack overflow on architectures using
> asm-generic/atomic.h, due to recursive invoking of, e.g.
> trace_hardirqs_off().
>
> trace_hardirqs_off() -> start_critical_timing() -> atomic_inc() ->
> atomic_add_return() -> local_irq_save() -> trace_hardirqs_off()
>
> Signed-off-by: Yi Li <yi.li@analog.com>
> ---
> include/asm-generic/atomic.h | 12 ++++++------
Arnd is watching over asm-generic/ atm
> @@ -60,11 +60,11 @@ static inline int atomic_add_return(int i, atomic_t
> *v)
> @@ -82,11 +82,11 @@ static inline int atomic_sub_return(int i, atomic_t
> *v)
> @@ -139,9 +139,9 @@ static inline void atomic_clear_mask(unsigned long
> mask, unsigned long *addr)
looks like your mailer has line wrapping problems ... might want to
fix that. maybe just find a smtp server in ADI shanghai's office to
send to and use sendemail.smtpersver in your ~/.gitconfig ?
-mike
next prev parent reply other threads:[~2010-01-08 4:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 4:45 Li Yi
2010-01-08 4:54 ` Mike Frysinger [this message]
2010-01-08 6:26 ` Li Yi
2010-01-08 6:26 ` Mike Frysinger
2010-01-08 5:18 ` Frederic Weisbecker
2010-01-08 9:13 ` Li Yi
2010-01-08 15:22 ` Steven Rostedt
2010-01-08 18:27 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a1001072054y798833dftdb1b2a744ad52969@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=yi.li@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®