From: Mike Frysinger <vapier.adi@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Blackfin arch: Fix decoding of opcodes 41-47 in decode_instruction()
Date: Sat, 9 Jan 2010 02:13:45 -0500 [thread overview]
Message-ID: <8bd0f97a1001082313h40b83a8cs22046a80c3120b38@mail.gmail.com> (raw)
In-Reply-To: <4B47822E.1080402@gmail.com>
On Fri, Jan 8, 2010 at 14:06, Roel Kluin wrote:
> This condition allowed only decoding of opcode 0x0040
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> arch/blackfin/kernel/traps.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Found with static code analysis. Correct?
looks like it to me:
0: 40 00 STI R0;
2: 41 00 STI R1;
4: 42 00 STI R2;
6: 43 00 STI R3;
8: 44 00 STI R4;
a: 45 00 STI R5;
c: 46 00 STI R6;
e: 47 00 STI R7;
ive added this to the Blackfin repo, thanks
-mike
prev parent reply other threads:[~2010-01-09 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 19:06 Roel Kluin
2010-01-09 7:13 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a1001082313h40b83a8cs22046a80c3120b38@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®