From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18949C001B0 for ; Wed, 26 Jul 2023 11:15:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232100AbjGZLPV (ORCPT ); Wed, 26 Jul 2023 07:15:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231825AbjGZLPT (ORCPT ); Wed, 26 Jul 2023 07:15:19 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F7B9FD for ; Wed, 26 Jul 2023 04:15:18 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-51e28cac164so1831420a12.1 for ; Wed, 26 Jul 2023 04:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690370116; x=1690974916; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lChKNKegfLv8YzWr0ThP7tf6+B40c9uLj92oms8T8Po=; b=gTAWzL3C03KYGkRM28j66FVMjwSAV38XkmSWVKDYY51ECYfGiDr/sjEg6Zr9wR6U7b jiJnswQu7mW4ovRiJFIILqi3SwerydIgFc/6VxpAgSthGQgiroNJDNeZmSSdNdnyEYFR XEoMs94wXxy6zt6Z2lySNUQ5N860t390ATyzPriDG+2IUVgrBxa7+ifdLqo1qW7PSnXm suPUYafUb2zi2ZwyRqI/LewS85pKdZokNGwNupyjHf2SKKuzqaK9fE+/hNI5a9cCIUe2 +Ugu5YOk2llGsmyq7sJqN7iiatcrnctA62xVqx/9/rvlLfu7gpDN03KFZLCThUY3/Dpd iZCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690370116; x=1690974916; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lChKNKegfLv8YzWr0ThP7tf6+B40c9uLj92oms8T8Po=; b=CtlPqIdR+o2wBt6H3tX0J2qWxJOZxj/OekCLZlyPqKhdAxpNFTSnnNdVEtshslR69+ 0FkqE5FayTFnQwnfJVnC1xmSYS7YozcagGHkqMqqq2xdo17ig7SSqWdPX8cqrFCe3DHK rKyuNMwu8keXoDf2BMzmxT33jKBCHDiO9UYdiSjj9mBfs7oTKonJ1Sv4h1zc/3N6LASb fHl/3USDTlsCDKhAN3VLHlKKzExpYmB0OmuLScGKG6i2vqa1+hFY0WgzOYxArHBl2jkJ e4kX5O+Y3TEC/OsQ9/n/lkjypf0Cl4WzC0APLXhw6WLePQQp7AN6sTi3J+WJYhZpzb/J 7Ugg== X-Gm-Message-State: ABy/qLYt5v8xzD5ESeWDSINeBOm9Z6GNhLltEgsHarzeVslYFQp2euhj fxnUCLhlkWMsOZ+2OqsOD7p+kg== X-Google-Smtp-Source: APBJJlG1Wgq0HOju4vWFnsvGKBJU9wiiZUckr5/BZIBoid1hxh0MHbzqfcNpHvRviJzmI2oczH6Wpw== X-Received: by 2002:a17:907:6d05:b0:994:fec:e1b7 with SMTP id sa5-20020a1709076d0500b009940fece1b7mr5592756ejc.0.1690370116633; Wed, 26 Jul 2023 04:15:16 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id m26-20020a170906849a00b00982a352f078sm9291152ejx.124.2023.07.26.04.15.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 04:15:16 -0700 (PDT) Message-ID: <8bd37e11-2861-7877-0321-3f89cd088532@linaro.org> Date: Wed, 26 Jul 2023 13:15:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V1 2/2] regulator: aw37503: add device-tree binding Content-Language: en-US To: like@awinic.com, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, liweilei@awinic.com, liangdong@awinic.com, wangweidong.a@awinic.com References: <20230726081612.586295-1-like@awinic.com> <20230726081612.586295-3-like@awinic.com> From: Krzysztof Kozlowski In-Reply-To: <20230726081612.586295-3-like@awinic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/07/2023 10:16, like@awinic.com wrote: > From: Alec Li > > Add aw37503 regulator device-tree binding documentation subject rather like: regulator: dt-bindings: Add Awinic aw37503 > > Signed-off-by: Alec Li > --- > .../bindings/regulator/awinic,aw37503.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/awinic,aw37503.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/awinic,aw37503.yaml b/Documentation/devicetree/bindings/regulator/awinic,aw37503.yaml > new file mode 100644 > index 000000000000..0cd6fb001e20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/awinic,aw37503.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/awinic,aw37503.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Awinic AW37503 Voltage Regulator > + > +maintainers: > + - Alec Li > + > +description: | Do not need '|' unless you need to preserve formatting. > + The AW37503 is dual voltage regulator, designed to support positive/negative > + supply for driving TFT-LCD panels. It support software-configurable output > + switching and monitoring. The output voltages can be programmed via an I2C > + compatible interface. > + > +properties: > + compatible: > + const: > + - awinic,aw37503 This has to be in one line. As pointed out by Rob's bot: please test it before sending. > + > + reg: > + maxItems: 1 > + > + patternProperties: > + "^out[pn]$": > + type: object > + $ref: regulator.yaml# > + unvaluatedproperties: false > + > + required: > + - regulator-name > + - enable-gpios regulator.yaml does not define enable-gpios, so you must define it in properties. > + > + additionalProperties: false Drop, you already have unevaluatedProperties. > + > +required: > + - compatible > + - reg > + - outp > + - outn > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + aw37503@3e { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof