mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ghatto <ghatto404@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: r0q: add touchscreen support
Date: Thu, 16 Oct 2025 12:06:37 +0200	[thread overview]
Message-ID: <8bd5486f-38a9-4104-8d09-234f642b45fe@oss.qualcomm.com> (raw)
In-Reply-To: <CAMQHOhe=WYhtsjHMcRnJOi8UhnNNBfveTWRGSZ_bg24gFysAEw@mail.gmail.com>



On 10/14/25 9:04 PM, Ghatto wrote:
> On Tue, Oct 14, 2025 at 11:18 AM Konrad Dybcio
> <konrad.dybcio@oss.qualcomm.com> wrote:
>>
>> On 10/14/25 5:10 PM, Ghatto wrote:
>>> On Tue, Oct 14, 2025 at 7:01 AM Konrad Dybcio
>>> <konrad.dybcio@oss.qualcomm.com> wrote:
>>>>
>>>> On 10/14/25 6:41 AM, Eric Gonçalves wrote:
>>>>> Enable the ST-Microelectronics FTS2BA61Y touchscreen. This patch
>>>>> depends on "Input: add support for the STM FTS2BA61Y touchscreen".
>>>>
>>>> The second sentence doesn't really make sense to be included in
>>>> the git log
>>> I'll keep it to the cover letter then
>>>>
>>>>> The device has an issue where SPI 8 (the bus which the touchscreen is
>>>>> connected to) is not working properly right now, so
>>>>> spi-gpio is used instead.
>>>>
>>>> Some Samsung devices used to use spi/i2c-gpio intentionally, also
>>>> on downstream. I'm assuming this isn't the case for r0q.
>>> It isn't, the device uses fts2ba61y on the spi8 bus - I hosted the
>>> DT at https://github.com/ghatt-o/ss_experiments/blob/main/r0q.dts if you
>>> want to take a look.
>>>>
>>>> Did you enable gpi_dma1, qupv3_id_1 before spi8, when testing
>>> The driver probes, but it fails to recognize the touchscreen device
>>
>> Could you post a complete dmesg and the precise DT diff you used?
> https://pastebin.com/QkYa8nMp (android dmesg) mainline dmesg doesn't have

The link has expired 🙁

> any relevant information other than spi/i2c probing, however, I've noticed
> both on deviceinfohw.ru and the dmesg that for some reason the touchscreen
> is on spi0.0 (even though DT says 8) and I'm not sure if that means it's on SPI
> but on a bugged out bus or if it's really just spi on bus 0

It means that it's on the SPI bus that probed first (index 0) 

[...]

> +&spi8 {
> +       spi-max-frequency = <5000000>;
> +
> +       touchscreen@0 {
> +               compatible = "st,fts2ba61y";
> +               reg = <0>;
> +
> +               vdd-supply = <&vreg_l8c_1p8>;
> +               avdd-supply = <&vreg_l11c_3p0>;
> +
> +               interrupt-parent = <&tlmm>;
> +               interrupts = <46 IRQ_TYPE_LEVEL_LOW>;
> +
> +               pinctrl-names = "default", "sleep";
> +               pinctrl-0 = <&tsp_int_active>;
> +               pinctrl-1 = <&tsp_int_sleep>;
> +
> +               status = "okay";
> +       };
> +
> +
> +       status = "okay";
> +};

this won't compile ^

Konrad


  reply	other threads:[~2025-10-16 10:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  4:41 [PATCH v2 0/6] arm64: dts: qcom: r0q: enable more peripherals Eric Gonçalves
2025-10-14  4:41 ` [PATCH v2 1/6] arm64: dts: qcom: r0q: small refactor Eric Gonçalves
2025-10-14  4:41 ` [PATCH v2 2/6] arm64: dts: qcom: r0q: add gpio keys Eric Gonçalves
2025-10-14  9:59   ` Konrad Dybcio
2025-10-14  4:41 ` [PATCH v2 3/6] arm64: dts: qcom: r0q: add touchscreen support Eric Gonçalves
2025-10-14 10:01   ` Konrad Dybcio
2025-10-14 15:10     ` Ghatto
2025-10-14 15:17       ` Konrad Dybcio
2025-10-14 19:04         ` Ghatto
2025-10-16 10:06           ` Konrad Dybcio [this message]
2025-10-16 20:08             ` Ghatto
2025-10-17  8:20               ` Konrad Dybcio
2025-10-17 18:22                 ` Eric Gonçalves
2025-10-20 12:18                   ` Konrad Dybcio
2025-10-27 18:32                     ` Eric Gonçalves
2025-10-29  9:50                       ` Konrad Dybcio
2025-10-31 21:06                         ` Ghatto
2025-11-04 14:53                           ` Konrad Dybcio
2025-10-14  4:41 ` [PATCH v2 4/6] arm64: dts: qcom: r0q: enable max77705 fuelgauge Eric Gonçalves
2025-10-14  4:41 ` [PATCH v2 5/6] arm64: dts: qcom: r0q: enable ufs storage Eric Gonçalves
2025-10-14 10:02   ` Konrad Dybcio
2025-10-14  4:41 ` [PATCH v2 6/6] arm64: dts: qcom: r0q: fix reserved memory regions Eric Gonçalves
2025-10-14 10:02   ` Konrad Dybcio
2025-10-14 15:12     ` Ghatto
2025-10-14  9:58 ` [PATCH v2 0/6] arm64: dts: qcom: r0q: enable more peripherals Konrad Dybcio
2025-10-31 21:12   ` Ghatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd5486f-38a9-4104-8d09-234f642b45fe@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ghatto404@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®