From: Eugen Hristev <eugen.hristev@linaro.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: andersson@kernel.org, konradybcio@kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: Rework BCM_TCS_CMD macro
Date: Mon, 28 Oct 2024 14:22:38 +0200 [thread overview]
Message-ID: <8bd63441-7414-4bc1-9044-b3f1e7b21384@linaro.org> (raw)
In-Reply-To: <6852b25f-94a4-4e04-adc5-5c79eb1f17ca@oss.qualcomm.com>
On 10/25/24 20:03, Konrad Dybcio wrote:
> On 25.10.2024 2:06 PM, Eugen Hristev wrote:
>>
>>
>> On 10/25/24 12:03, Konrad Dybcio wrote:
>>> On 25.10.2024 10:48 AM, Eugen Hristev wrote:
>>>> Reworked BCM_TCS_CMD macro in order to fix warnings from sparse:
>>>>
>>>> drivers/clk/qcom/clk-rpmh.c:270:28: warning: restricted __le32 degrades to integer
>>>> drivers/clk/qcom/clk-rpmh.c:270:28: warning: restricted __le32 degrades to integer
>>>>
>>>> While at it, used u32_encode_bits which made the code easier to
>>>> follow and removed unnecessary shift definitions.
>>>>
>>>> Signed-off-by: Eugen Hristev <eugen.hristev@linaro.org>
>>>> ---
>>>> include/soc/qcom/tcs.h | 19 ++++++++-----------
>>>> 1 file changed, 8 insertions(+), 11 deletions(-)
>>>>
>>>> diff --git a/include/soc/qcom/tcs.h b/include/soc/qcom/tcs.h
>>>> index 3acca067c72b..130ed2582f37 100644
>>>> --- a/include/soc/qcom/tcs.h
>>>> +++ b/include/soc/qcom/tcs.h
>>>> @@ -60,22 +60,19 @@ struct tcs_request {
>>>> struct tcs_cmd *cmds;
>>>> };
>>>> -#define BCM_TCS_CMD_COMMIT_SHFT 30
>>>> #define BCM_TCS_CMD_COMMIT_MASK 0x40000000
>>>> -#define BCM_TCS_CMD_VALID_SHFT 29
>>>> #define BCM_TCS_CMD_VALID_MASK 0x20000000
>>>> -#define BCM_TCS_CMD_VOTE_X_SHFT 14
>>>> #define BCM_TCS_CMD_VOTE_MASK 0x3fff
>>>> -#define BCM_TCS_CMD_VOTE_Y_SHFT 0
>>>> -#define BCM_TCS_CMD_VOTE_Y_MASK 0xfffc000
>>>> +#define BCM_TCS_CMD_VOTE_Y_MASK 0x3fff
>>>> +#define BCM_TCS_CMD_VOTE_X_MASK 0xfffc000
>>>> /* Construct a Bus Clock Manager (BCM) specific TCS command */
>>>> #define BCM_TCS_CMD(commit, valid, vote_x, vote_y) \
>>>> - (((commit) << BCM_TCS_CMD_COMMIT_SHFT) | \
>>>> - ((valid) << BCM_TCS_CMD_VALID_SHFT) | \
>>>> - ((cpu_to_le32(vote_x) & \
>>>> - BCM_TCS_CMD_VOTE_MASK) << BCM_TCS_CMD_VOTE_X_SHFT) | \
>>>> - ((cpu_to_le32(vote_y) & \
>>>> - BCM_TCS_CMD_VOTE_MASK) << BCM_TCS_CMD_VOTE_Y_SHFT))
>>>> + (u32_encode_bits(commit, BCM_TCS_CMD_COMMIT_MASK) | \
>>>> + u32_encode_bits(valid, BCM_TCS_CMD_VALID_MASK) | \
>>>> + u32_encode_bits((__force u32)cpu_to_le32(vote_x), \
>>>> + BCM_TCS_CMD_VOTE_X_MASK) | \
>>>> + u32_encode_bits((__force u32)cpu_to_le32(vote_y), \
>>>> + BCM_TCS_CMD_VOTE_Y_MASK))
>>>
>>> FIELD_PREP/GET?
>>>
>>> Konrad
>>
>> What would be the difference/advantage in using FIELD_PREP/GET instead of u32_encode_bits ?
>
> Probably none. I thought it was a function and not another magic macro,
> as it's lowercase..
>
> Doesn't le32_encode_bits do what you need then?
That works too. It would move the `__force u32` to a higher level, but
works. I am sending a v2 with that.
>
> Konrad
next prev parent reply other threads:[~2024-10-28 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 8:48 Eugen Hristev
2024-10-25 9:03 ` Konrad Dybcio
2024-10-25 12:06 ` Eugen Hristev
2024-10-25 17:03 ` Konrad Dybcio
2024-10-28 12:22 ` Eugen Hristev [this message]
2024-10-25 21:06 ` kernel test robot
2024-10-26 7:47 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd63441-7414-4bc1-9044-b3f1e7b21384@linaro.org \
--to=eugen.hristev@linaro.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®