From: Chen Yu <yu.c.chen@intel.com>
To: tony.luck@intel.com, reinette.chatre@intel.com
Cc: tglx@kernel.org, bp@alien8.de, mingo@redhat.com,
dave.hansen@linux.intel.com, hpa@zytor.com, fenghuay@nvidia.com,
babu.moger@amd.com, hongyu.ning@intel.com, chen.yu@linux.dev,
x86@kernel.org, linux-kernel@vger.kernel.org,
Chen Yu <yu.c.chen@intel.com>,
Hongyu Ning <hongyu.ning@linux.intel.com>
Subject: [PATCH v9 11/12] x86/resctrl: Introduce erdt_cpu_has() and erdt_support()
Date: Wed, 14 Oct 2026 11:00:52 +0800 [thread overview]
Message-ID: <8bd80a7e1746e9312e3ee1b875ec9bb983aeb19c.1791933001.git.yu.c.chen@intel.com> (raw)
In-Reply-To: <cover.1791933001.git.yu.c.chen@intel.com>
Introduce erdt_cpu_has() to verify if a specific RDT feature is backed by an
ERDT table. A feature is only reported as ERDT backed when the CPU enumerates
it via CPUID and firmware describes it in the ERDT table (and its sub-tables).
erdt_cpu_has() also considers userspace input like "rdt=!cmt". Similar to
rdt_cpu_has(), erdt_cpu_has() expects an x86 feature flag as parameter.
Introduce erdt_support() as a helper called by erdt_cpu_has() to check whether
the ERDT firmware supports a given feature.
erdt_support() deliberately claims no feature yet and returns false. Features
should be added to erdt_support() as their MMIO implementations are introduced.
Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
Tested-by: Hongyu Ning <hongyu.ning@linux.intel.com>
---
Changes since v8:
- Factor the "rdt=" option handling out of rdt_cpu_has() into
apply_rdt_options() and build both rdt_cpu_has() and erdt_cpu_has() on
top of it instead of duplicating the loop. (Reinette Chatre)
- CPUID stays the architectural enumeration mechanism, so erdt_cpu_has()
now requires boot_cpu_has(flag) in addition to ERDT firmware support.
(Reinette Chatre)
- Do not add the erdt_cpu_has()/erdt_get_scale() prototypes to
asm/resctrl.h, they live in the resctrl internal header now that
resctrl_arch_round_mon_val() is out of line. (Reinette Chatre)
- Reword the changelog: use imperative mood instead of "is derived
from", and do not imply that rdt_cpu_has() considers ERDT.
(Reinette Chatre)
arch/x86/kernel/cpu/resctrl/core.c | 13 +++++++++++--
arch/x86/kernel/cpu/resctrl/erdt.c | 5 +++++
arch/x86/kernel/cpu/resctrl/internal.h | 2 ++
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index 9a59643f366c..f8737d9b2e20 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -872,9 +872,8 @@ static int __init set_rdt_options(char *str)
}
__setup("rdt", set_rdt_options);
-bool rdt_cpu_has(int flag)
+static bool apply_rdt_options(int flag, bool ret)
{
- bool ret = boot_cpu_has(flag);
struct rdt_options *o;
if (!ret)
@@ -892,6 +891,16 @@ bool rdt_cpu_has(int flag)
return ret;
}
+bool rdt_cpu_has(int flag)
+{
+ return apply_rdt_options(flag, boot_cpu_has(flag));
+}
+
+bool erdt_cpu_has(int flag)
+{
+ return apply_rdt_options(flag, boot_cpu_has(flag) && erdt_support(flag));
+}
+
bool resctrl_arch_is_evt_configurable(enum resctrl_event_id evt)
{
if (!rdt_cpu_has(X86_FEATURE_BMEC))
diff --git a/arch/x86/kernel/cpu/resctrl/erdt.c b/arch/x86/kernel/cpu/resctrl/erdt.c
index 1e6cfc6dbc38..110e7b9806b4 100644
--- a/arch/x86/kernel/cpu/resctrl/erdt.c
+++ b/arch/x86/kernel/cpu/resctrl/erdt.c
@@ -50,6 +50,11 @@ static unsigned int erdt_max_rmid;
*/
static unsigned int erdt_scale;
+bool erdt_support(int flag)
+{
+ return false;
+}
+
unsigned int erdt_get_scale(void)
{
return erdt_scale;
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index 0de174df26e9..88fae7a84fc7 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -288,6 +288,8 @@ static inline void intel_aet_mon_domain_setup(int cpu, int id, struct rdt_resour
static inline bool intel_handle_aet_option(bool force_off, char *tok) { return false; }
#endif
+bool erdt_cpu_has(int flag);
+bool erdt_support(int flag);
unsigned int erdt_get_scale(void);
void erdt_init(void);
void erdt_exit(void);
--
2.43.0
next prev parent reply other threads:[~2026-10-14 3:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 2:56 [PATCH v9 00/12] Introduce MMIO-based CMT access for Enhanced RDT Chen Yu
2026-10-14 2:57 ` [PATCH v9 01/12] x86/topology: Export topo_lookup_cpuid() for resctrl use Chen Yu
2026-10-14 2:58 ` [PATCH v9 02/12] x86/resctrl: Require 64-bit x86 for resctrl support Chen Yu
2026-10-14 2:58 ` [PATCH v9 03/12] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask per RMD Chen Yu
2026-10-14 2:58 ` [PATCH v9 04/12] x86/resctrl: Do not enable ERDT when Sub-NUMA Cluster is enabled Chen Yu
2026-10-14 2:58 ` [PATCH v9 05/12] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online Chen Yu
2026-10-14 2:59 ` [PATCH v9 06/12] x86,fs/resctrl: Move resctrl_arch_round_mon_val() out of line Chen Yu
2026-10-14 2:59 ` [PATCH v9 07/12] x86/resctrl: Add a global ERDT monitor scale Chen Yu
2026-10-14 2:59 ` [PATCH v9 08/12] x86/resctrl: Parse ACPI CMRC table Chen Yu
2026-10-14 3:00 ` [PATCH v9 09/12] x86/resctrl: Refactor the monitor read function Chen Yu
2026-10-14 3:00 ` [PATCH v9 10/12] fs/resctrl: Do not invoke smp_processor_id() in preemptible context Chen Yu
2026-10-14 3:00 ` Chen Yu [this message]
2026-10-14 3:01 ` [PATCH v9 12/12] x86/resctrl: Add MMIO-based LLC occupancy monitoring support Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd80a7e1746e9312e3ee1b875ec9bb983aeb19c.1791933001.git.yu.c.chen@intel.com \
--to=yu.c.chen@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chen.yu@linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=hongyu.ning@intel.com \
--cc=hongyu.ning@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®