From: Rodolfo Giometti <giometti@enneenne.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pps: gpio: Correct indentation and style in DTS example
Date: Mon, 24 Mar 2025 14:15:39 +0100 [thread overview]
Message-ID: <8bd8ca96-1334-42c7-8dc4-2db1785301b9@enneenne.com> (raw)
In-Reply-To: <20250324125122.81810-1-krzysztof.kozlowski@linaro.org>
On 24/03/25 13:51, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
> ---
> .../devicetree/bindings/pps/pps-gpio.yaml | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.yaml b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> index fd4adfa8d2d4..383a838744eb 100644
> --- a/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> @@ -36,14 +36,14 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/gpio/gpio.h>
>
> - pps {
> - compatible = "pps-gpio";
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_pps>;
> - gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> - assert-falling-edge;
> - echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
> - echo-active-ms = <100>;
> - };
> + pps {
> + compatible = "pps-gpio";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pps>;
> + gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> + assert-falling-edge;
> + echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
> + echo-active-ms = <100>;
> + };
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming
next prev parent reply other threads:[~2025-03-24 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:51 Krzysztof Kozlowski
2025-03-24 13:15 ` Rodolfo Giometti [this message]
2025-03-25 3:15 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd8ca96-1334-42c7-8dc4-2db1785301b9@enneenne.com \
--to=giometti@enneenne.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®