From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Komal Bajaj <quic_kbajaj@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region
Date: Wed, 5 Jul 2023 16:21:25 +0200 [thread overview]
Message-ID: <8bd8ffbe-f50d-6e4a-2fdf-3983a76fb5ad@linaro.org> (raw)
In-Reply-To: <20230705110620.7687-2-quic_kbajaj@quicinc.com>
On 05/07/2023 13:06, Komal Bajaj wrote:
> Add missing reserved regions as described in QDU1000 memory map.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> index 1d22f87fd238..47e5e31dde23 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> @@ -448,6 +448,28 @@ &qupv3_id_0 {
> status = "okay";
> };
>
> +&reserved_memory{
> + ecc_meta_data_mem: memory@e0000000{
Missing spaces before '{'. I was correcting this already:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66b14154e278807811d67de9fb0d5cc76638d07b
so it seems I need to keep doing the same.
Anyway, the names should follow purpose, not "memory". See link from Konrad.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-05 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 11:06 [PATCH v2 0/2] arm64: dts: qcom: qdu1000: " Komal Bajaj
2023-07-05 11:06 ` [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: " Komal Bajaj
2023-07-05 14:21 ` Krzysztof Kozlowski [this message]
2023-07-05 14:33 ` Dmitry Baryshkov
2023-07-06 12:45 ` Komal Bajaj
2023-07-05 11:06 ` [PATCH v2 2/2] arm64: dts: qcom: qru1000-idp: " Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd8ffbe-f50d-6e4a-2fdf-3983a76fb5ad@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®