From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE5653A9D86 for ; Mon, 13 Apr 2026 08:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776069053; cv=none; b=luT/8u7GOM4rlkA1xkA1E3E5R94do1DUriv+WFAWMmsIAKYP7HeSsa2u2JM2biJkPCvSSsm3ysduvCkc5CaxmQAAo9DvYF0X8vUVSLXgy33LLlcqbg+urWCG2Cb0ynaLU5S4tLv6bgv5cHquPfg44KzwKzZ9UQvep+t4und/xn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776069053; c=relaxed/simple; bh=RFHIm2Sf0rt3owYwPBLSJ4ZIUoXyzf+Q4lHrYTPMaSU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oq31OD4QMSaScQFQJRkRoNYfS+48f+1Z9mIhZdumx5q0zaku/QSzKwjyXiQHM4eNotnIpORAR9h9u+aHKh4sPXEE85/wxBlI/YJQZUGiHfwcoBbFIgBeCjgxuAlSL7xms2nYppu8eMGJgvkBBK4S2viqJwvdiNJFAWSSuL9vW38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=sRgWKPoQ; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="sRgWKPoQ" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 370E635A6; Mon, 13 Apr 2026 01:30:44 -0700 (PDT) Received: from [10.57.61.173] (unknown [10.57.61.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A5683F641; Mon, 13 Apr 2026 01:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776069049; bh=RFHIm2Sf0rt3owYwPBLSJ4ZIUoXyzf+Q4lHrYTPMaSU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sRgWKPoQHJHcJ1UBIp3DIbF5++EBsP6n06u0lDoKLYwA3otYtOfl3eA2xDufoKHIf tfERiSCPA8F9v+1/5WyiseslUFr152Cte2GY+bN/MDbS4JyNa3QEx3FWPQa0KoWnsg HEqeGmRC5+/QTgogguLbpNfrhN5bUMaZwnLm2zCw= Message-ID: <8bdc4347-c8ed-40e8-b55b-5d5cd6392653@arm.com> Date: Mon, 13 Apr 2026 09:30:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] virt: arm-cca-guest: fix error check for RSI_INCOMPLETE To: Sami Mujawar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: catalin.marinas@arm.com, will@kernel.org, suzuki.poulose@arm.com, gshan@redhat.com, YeoReum.Yun@arm.com, Jagdish Gediya References: <20260410163636.259443-1-sami.mujawar@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20260410163636.259443-1-sami.mujawar@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/04/2026 17:36, Sami Mujawar wrote: > The RSI interface can return RSI_INCOMPLETE when a report spans > multiple granules. This is an expected condition and should not be > treated as a fatal error. > > Currently, arm_cca_report_new() checks for `info.result != RSI_SUCCESS` > and bails out, which incorrectly flags RSI_INCOMPLETE as a failure. > Fix the check to only break out on results other than RSI_SUCCESS or > RSI_INCOMPLETE. > > This ensures partial reports are handled correctly and avoids spurious > -ENXIO errors when generating attestation reports. > > Fixes: 7999edc484ca ("virt: arm-cca-guest: TSM_REPORT support for realms") > Signed-off-by: Sami Mujawar > Reported-by: Jagdish Gediya Reviewed-by: Steven Price > --- > drivers/virt/coco/arm-cca-guest/arm-cca-guest.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c b/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c > index 0c9ea24a200c..66d00b6ceb78 100644 > --- a/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c > +++ b/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c > @@ -157,7 +157,8 @@ static int arm_cca_report_new(struct tsm_report *report, void *data) > } while (info.result == RSI_INCOMPLETE && > info.offset < RSI_GRANULE_SIZE); > > - if (info.result != RSI_SUCCESS) { > + /* Break out in case of failure */ > + if (info.result != RSI_SUCCESS && info.result != RSI_INCOMPLETE) { > ret = -ENXIO; > token_size = 0; > goto exit_free_granule_page;