mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"shuah@kernel.org" <shuah@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] selftests: add option to list all available tests
Date: Thu, 13 Jan 2022 08:21:26 -0700	[thread overview]
Message-ID: <8bde7cdc-6bd5-d50e-ea44-dfb480b88ca0@gmail.com> (raw)
In-Reply-To: <b76c51c6-80b6-c3ec-f416-f5e48aa5a6c5@fujitsu.com>

On 1/12/22 10:53 PM, lizhijian@fujitsu.com wrote:
> ping

seems to have been lost in the void

> 
> 
> On 02/12/2021 10:29, Li Zhijian wrote:
>> $ ./fcnal-test.sh -l
>> Test names: ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter
>> ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter
>> use_cases
>>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>>   tools/testing/selftests/net/fcnal-test.sh | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
>> index 5cb59947eed2..7e78be99aa4c 100755
>> --- a/tools/testing/selftests/net/fcnal-test.sh
>> +++ b/tools/testing/selftests/net/fcnal-test.sh
>> @@ -3993,6 +3993,7 @@ usage: ${0##*/} OPTS
>>   	-4          IPv4 tests only
>>   	-6          IPv6 tests only
>>   	-t <test>   Test name/set to run
>> +	-l          List all available tests
>>   	-p          Pause on fail
>>   	-P          Pause after each test
>>   	-v          Be verbose
>> @@ -4006,10 +4007,15 @@ TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
>>   TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
>>   TESTS_OTHER="use_cases"
>>   
>> +list()
>> +{
>> +	echo "Test names: $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER"
>> +}

Just add the test list at the end of usage() like this:

@@ -4019,6 +4019,9 @@ usage: ${0##*/} OPTS
        -p          Pause on fail
        -P          Pause after each test
        -v          Be verbose
+
+Tests:
+       $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER
 EOF
 }




  reply	other threads:[~2022-01-13 15:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  2:29 [PATCH v2 1/2] selftests: net: remove meaningless help option Li Zhijian
2021-12-02  2:29 ` [PATCH v2 2/2] selftests: add option to list all available tests Li Zhijian
2022-01-13  5:53   ` lizhijian
2022-01-13 15:21     ` David Ahern [this message]
2022-01-14  1:54       ` lizhijian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bde7cdc-6bd5-d50e-ea44-dfb480b88ca0@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome