From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3641A3876BB for ; Sat, 1 Aug 2026 14:51:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785595902; cv=none; b=nNoJNuVl1eDD8651xfjmMDSqM+Q8Or/Qfi443EQr94CGxdUfM0sEAYgI7aVNtiDAY35GQyimTWi0I9rwwiW5TDUzb+o4/vRO2ZJislk93TXZvgNXcW8Ef6wEFhn8LOmCEzsi7QOkrMuDmvkd9/MwO4GrA9xErGT/26ZFtF+iwqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785595902; c=relaxed/simple; bh=8P+MLcg11rQC4vMX7sSebrnUADYIE5rfOaK2TFG976Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FHBPixmHZWwRw0IT2iOe1+014/EqxpotcyJfGDg0bJs/W/+qbld2NvM0vFawxJ2Lb4ZtEggDQ3WGV0OKJlRWHO8zV16NJNHIwYe1jaMpGL0h59EejxC25uGIXW6rv3gh2NBqwBqsLBhfP95qGGl8DVF8eNe/hpNFTWuNwTGVMLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=QbpZJu8n; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="QbpZJu8n" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-6aca0f482e5so1251643eaf.2 for ; Sat, 01 Aug 2026 07:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785595900; x=1786200700; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=biNkA50kN2GCvNIWKTTRsuGKERA58n0pu0i9eBii5iE=; b=QbpZJu8ncb+yNcbT58EU96yxDGfrD398z8h4iOirckLUJdRkbVQ28XJG6hv0y1EitF RB0T5aTqfkhl/uF1CJYngU2ITDRtrZpnfbat2sr8WViYVmRjJM1XF+Kqc9JOv6weyCw7 Om0tilVxV3UksZTx1N0B1WoEQLCSx6uDkP4EEufx9NhAYKL+QPmHnnwUx9mwltmoTMJb mSzKj9MNVL1Tg08aLJPzBpSN85rw0HzmQcbgL/9VFyhbzn5jlr1os5pP3r7EOZGKVfY/ ss09QYmTqIKqazMSCfk0LjsDDJGXrweVPpRvFrjQE5tgO+FqYvkRzxAfBIh2f6/JrzGm CUjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785595900; x=1786200700; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=biNkA50kN2GCvNIWKTTRsuGKERA58n0pu0i9eBii5iE=; b=ID2U/gsAuTHosMqGNO/bl+JZ0FCGuHnLAGhzWDt7BKg/Y9uJUZG7vzsU/iSEurfgls Pn/wNPsDEfycMRLbPBqYSsOW5Y6DaBkwhVsKjbuPF1qOm9d9NZKQDZiUJTem7Z6nVNTf VfDa6XCNfo1Qa5itUC07eW6V1JrRPidhxZWHQgwYGVQ3L1CcAX3tlfyx9KFg0t3gDtXJ YoXD9QlRjq48yc+f+/hbt98yIAax7Sqn7kQL7lEvbyW+/IGpLS3+kQwPmtxxPfXIsIy+ WwXu8H7pOKGCYdjGF5WrjK6Kmb0hMy26KcwnIojo9W/eNIU+vbpyT9H0vTB0CH/68X3R yApw== X-Forwarded-Encrypted: i=1; AHgh+Rq+XQZW0Rbkw9q8p5NHZDZgonRRreQmFbc55l6UgTHjWxFcE7fd4eYMoakIRRazbOPkJz7gWORuNHu0L20=@vger.kernel.org X-Gm-Message-State: AOJu0YwD5jNhr5Iz0Px+YIT+YIVjv5V8nDA/63JHFCuvE+NR0fiZSzub nd6Rw+Ds24WAeOUBXk/zGN7egGEt+DSg6PO09/HT7RVYo2hzAFxjPDQDmhromJ9bUyk= X-Gm-Gg: AR+sD12PXIfWL5Spp2Yjd3SuYBvpeHgn9YnUo4NsfY7uGw9w0jmW/d3NyVX63uJBLzL GlFWq9GRkrC5wQUOYNp7ca6F0zIX6KcEsvuBuvDZPxmC4oLjX0X7my/uQelw3x3pyzL3WUTwEpP uwJMzgNU9nxcbDJ8kfRwXZoCDJe95obkN36XyGxpXwDvGq+398tkbzG2FxAl9TdfZt28JfTZQWd SrFkQUh5oet4MNUQl3PeY0fFavFD4/6mlHViHTuXHy0OH7pLGzwxmQuxKP4ynv4etigAypJeW6B arZ5q8w5Ay4ZCTMUepaO0u+5jouTcRx8MSL/Yv1y6qfckO3blqh9u6HAjlpJvu0eR8XZThlHc8N acbceAHqD6teGsTUQnqht7ks/JSrOQekY00xKeR5FaTFSEGjJd+oca2+QyMji3RMivBIGISazzR FnoPUJaeU7mH5VSb9hzjLTn/tv3QkYAW0j9mrDOlaeqy7qtoDv4r3gcXP3usj8N4xu5Ob6Oyilc Yf6oZV0f+1Wq7dlZVc40VxevrO4QCphUnjfwzo= X-Received: by 2002:a05:6820:4b02:b0:6ac:c531:2ef4 with SMTP id 006d021491bc7-6ae43336570mr7319764eaf.26.1785595898078; Sat, 01 Aug 2026 07:51:38 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:359b:17f1:d4f9:4949? ([2600:8803:e7e4:500:359b:17f1:d4f9:4949]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-458f66c1d89sm3908964fac.13.2026.08.01.07.51.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Aug 2026 07:51:36 -0700 (PDT) Message-ID: <8be00e0f-08ca-4744-9f24-eb41a63a858e@baylibre.com> Date: Sat, 1 Aug 2026 09:51:34 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() To: mdshahid03@gmail.com, Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Nuno_S=C3=A1?= , Ray Jui , Scott Branden References: <20260801090953.61603-1-mdshahid03@gmail.com> <20260801090953.61603-4-mdshahid03@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260801090953.61603-4-mdshahid03@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/26 4:09 AM, mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > This simplifies the probe error handling by replacing open-coded > dev_err() and return sequences while preserving the existing > messages. > > Signed-off-by: Mohammad Shahid > --- > drivers/iio/adc/bcm_iproc_adc.c | 39 +++++++++++++++------------------ > 1 file changed, 18 insertions(+), 21 deletions(-) > > diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c > index 4acd9c3f089b..5fcd528eb88a 100644 > --- a/drivers/iio/adc/bcm_iproc_adc.c > +++ b/drivers/iio/adc/bcm_iproc_adc.c > @@ -523,19 +523,16 @@ static int iproc_adc_probe(struct platform_device *pdev) > > adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, > "adc-syscon"); > - if (IS_ERR(adc_priv->regmap)) { > - dev_err(dev, "failed to get handle for tsc syscon\n"); > - ret = PTR_ERR(adc_priv->regmap); > - return ret; > - } > + if (IS_ERR(adc_priv->regmap)) > + return dev_err_probe(dev, > + PTR_ERR(adc_priv->regmap), Probably fine to put this on the same line as dev since it won't be any longer than the text below. > + "failed to get handle for tsc syscon\n"); > > adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); > - if (IS_ERR(adc_priv->adc_clk)) { > - dev_err(dev, > - "failed getting clock tsc_clk\n"); > - ret = PTR_ERR(adc_priv->adc_clk); > - return ret; > - } > + if (IS_ERR(adc_priv->adc_clk)) > + return dev_err_probe(dev, > + PTR_ERR(adc_priv->adc_clk), same > + "failed getting clock tsc_clk\n"); > > adc_priv->irqno = platform_get_irq(pdev, 0); > if (adc_priv->irqno < 0) > @@ -543,10 +540,10 @@ static int iproc_adc_probe(struct platform_device *pdev) > > ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, > IPROC_ADC_AUXIN_SCAN_ENA); > - if (ret) { > - dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, > + ret, dev and ret should be on the same line. > + "failed to write IPROC_REGCTL2\n"); > > ret = devm_request_threaded_irq(dev, adc_priv->irqno, > iproc_adc_interrupt_handler, > @@ -556,11 +553,10 @@ static int iproc_adc_probe(struct platform_device *pdev) > return ret; > > ret = clk_prepare_enable(adc_priv->adc_clk); > - if (ret) { > - dev_err(dev, > - "clk_prepare_enable failed %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, > + ret, same > + "failed to enable clock\n"); > > ret = iproc_adc_enable(indio_dev); > if (ret) > @@ -574,7 +570,8 @@ static int iproc_adc_probe(struct platform_device *pdev) > > ret = iio_device_register(indio_dev); > if (ret) { > - dev_err(dev, "iio_device_register failed:err %d\n", ret); > + dev_err_probe(dev, ret, > + "failed to register IIO device\n"); > goto err_clk; > } >